Introducing the OffDomainInclusionDetector to analyze resource requests for suspicious activity.

chrome/browser/safe_browsing/safe_browsing_service.h

Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index 9a8b3da62e8c7ee96a9159241e21f991c94085e3..d69f5853e9272c782cd8ee5023bbd9fa61e23b06 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -44,6 +44,7 @@ class DownloadManager;
 }
 
 namespace net {
+class URLRequest;
 class URLRequestContext;
 class URLRequestContextGetter;
 }
@@ -52,6 +53,7 @@ namespace safe_browsing {
 class ClientSideDetectionService;
 class DownloadProtectionService;
 class IncidentReportingService;
+class OffDomainInclusionDetector;
 }
 
 // Construction needs to happen on the main thread.
@@ -138,6 +140,10 @@ class SafeBrowsingService
   // Adds |download_manager| to the set monitored by safe browsing.
   void AddDownloadManager(content::DownloadManager* download_manager);
 
+  // Observes resource requests made by the renderer and reports suspicious
+  // activity.
+  void OnResourceRequest(const net::URLRequest* request);
+
  protected:
   // Creates the safe browsing service.  Need to initialize before using.
   SafeBrowsingService();
@@ -254,6 +260,9 @@ class SafeBrowsingService
   // both UI and IO thread.
   scoped_refptr<SafeBrowsingDatabaseManager> database_manager_;
 
+  scoped_ptr<safe_browsing::OffDomainInclusionDetector>

[grt (UTC plus 2), 2014/11/19 18:29:00]

this and incident_service_ should probably be wrapped in #if
defined(FULL_SAFE_BROWSING) blocks. possibly database_manager_,
download_service_ and csd_service_ as well. i think it's because they have
virtual dtors that was allowing this to build non-FULL_SAFE_BROWSING platforms.

[gab, 2014/11/19 21:29:09]

It builds fine on all platforms with GYP, only GN platforms had problems. Adding
ifdefs here implies ifdef changes all over the .cc file as well and I'd rather
avoid that in this CL.

I'll see if this builds with your recent GN safe_browsing fix
(http://crrev.com/304857).

+      off_domain_inclusion_detector_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingService);
 };