Introducing the OffDomainInclusionDetector to analyze resource requests for suspicious activity.

chrome/browser/safe_browsing/safe_browsing_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The Safe Browsing service is responsible for downloading anti-phishing and
 // anti-malware tables and checking urls against them.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 #define CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_
 
@@ skipping 26 matching lines @@
 
 namespace base {
 class Thread;
 }
 
 namespace content {
 class DownloadManager;
 }
 
 namespace net {
+class URLRequest;
 class URLRequestContext;
 class URLRequestContextGetter;
 }
 
 namespace safe_browsing {
 class ClientSideDetectionService;
 class DownloadProtectionService;
 class IncidentReportingService;
+class OffDomainInclusionDetector;
 }
 
 // Construction needs to happen on the main thread.
 // The SafeBrowsingService owns both the UI and Database managers which do
 // the heavylifting of safebrowsing service. Both of these managers stay
 // alive until SafeBrowsingService is destroyed, however, they are disabled
 // permanently when Shutdown method is called.
 class SafeBrowsingService
     : public base::RefCountedThreadSafe<
           SafeBrowsingService,
@@ skipping 66 matching lines @@
 
   // Registers |callback| to be run after some delay following process launch.
   // |callback| will be dropped if the service is not applicable for the
   // process.
   void RegisterDelayedAnalysisCallback(
       const safe_browsing::DelayedAnalysisCallback& callback);
 
   // Adds |download_manager| to the set monitored by safe browsing.
   void AddDownloadManager(content::DownloadManager* download_manager);
 
+  // Observes resource requests made by the renderer and reports suspicious
+  // activity.
+  void OnResourceRequest(const net::URLRequest* request);
+
  protected:
   // Creates the safe browsing service.  Need to initialize before using.
   SafeBrowsingService();
 
   ~SafeBrowsingService() override;
 
   virtual SafeBrowsingDatabaseManager* CreateDatabaseManager();
 
   virtual SafeBrowsingUIManager* CreateUIManager();
 
@@ skipping 96 matching lines @@
   scoped_ptr<safe_browsing::IncidentReportingService> incident_service_;
 
   // The UI manager handles showing interstitials.  Accessed on both UI and IO
   // thread.
   scoped_refptr<SafeBrowsingUIManager> ui_manager_;
 
   // The database manager handles the database and download logic.  Accessed on
   // both UI and IO thread.
   scoped_refptr<SafeBrowsingDatabaseManager> database_manager_;
 
+  scoped_ptr<safe_browsing::OffDomainInclusionDetector>

[grt (UTC plus 2), 2014/11/19 18:29:00]

this and incident_service_ should probably be wrapped in #if
defined(FULL_SAFE_BROWSING) blocks. possibly database_manager_,
download_service_ and csd_service_ as well. i think it's because they have
virtual dtors that was allowing this to build non-FULL_SAFE_BROWSING platforms.

[gab, 2014/11/19 21:29:09]

It builds fine on all platforms with GYP, only GN platforms had problems. Adding
ifdefs here implies ifdef changes all over the .cc file as well and I'd rather
avoid that in this CL.

I'll see if this builds with your recent GN safe_browsing fix
(http://crrev.com/304857).

+      off_domain_inclusion_detector_;
+
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingService);
 };
 
 // Factory for creating SafeBrowsingService.  Useful for tests.
 class SafeBrowsingServiceFactory {
  public:
   SafeBrowsingServiceFactory() { }
   virtual ~SafeBrowsingServiceFactory() { }
   virtual SafeBrowsingService* CreateSafeBrowsingService() = 0;
  private:
   DISALLOW_COPY_AND_ASSIGN(SafeBrowsingServiceFactory);
 };
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_SAFE_BROWSING_SERVICE_H_