Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 516603003: Revert of Make the compositing assert disabler for paint invalidation more targeted. (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 3 months ago
CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert of Make the compositing assert disabler for paint invalidation more targeted. (patchset #4 of https://codereview.chromium.org/506553004/) Reason for revert: This seems to be asserting in many PPAPI tests. For example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT%20Blink&tests=OutOfProcessPPAPITest.FlashFullscreen&testType=browser_tests Original issue's description: > Make the compositing assert disabler for paint invalidation more targeted. > > BUG=360286 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180997 TBR=abarth@chromium.org,chrishtr@chromium.org NOTREECHECKS=true NOTRY=true BUG=360286 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181025

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -41 lines) Patch
M Source/core/editing/Caret.cpp View 3 chunks +1 line, -6 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/rendering/RenderImage.cpp View 3 chunks +1 line, -3 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderView.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mlamouri (slow - plz ping)
Created Revert of Make the compositing assert disabler for paint invalidation more targeted.
6 years, 3 months ago (2014-08-28 10:43:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/516603003/1
6 years, 3 months ago (2014-08-28 10:44:35 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-08-28 10:45:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181025

Powered by Google App Engine
This is Rietveld 408576698