Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 516543004: Cleanup: Remove unneeded media/ SSE2 checks and unused code. (try 2) (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove unneeded media/ SSE2 checks and unused code. (try 2) This is the media/ portion of a reverted CL: https://codereview.chromium.org/459603003/ BUG=349320 Committed: https://crrev.com/a5fa6d9c5e117a1ae09014f71245cc62a35936cf Cr-Commit-Position: refs/heads/master@{#292294}

Patch Set 1 : Previous CL #

Patch Set 2 : remove more stuff #

Patch Set 3 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -460 lines) Patch
M media/base/BUILD.gn View 1 3 chunks +0 lines, -10 lines 0 comments Download
M media/base/simd/convert_yuv_to_rgb.h View 4 chunks +0 lines, -35 lines 0 comments Download
D media/base/simd/convert_yuv_to_rgb_mmx.asm View 1 chunk +0 lines, -23 lines 0 comments Download
M media/base/simd/convert_yuv_to_rgb_x86.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M media/base/simd/filter_yuv.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
D media/base/simd/filter_yuv_mmx.cc View 1 1 chunk +0 lines, -79 lines 0 comments Download
M media/base/yuv_convert.cc View 1 1 chunk +17 lines, -27 lines 0 comments Download
M media/base/yuv_convert_perftest.cc View 1 2 4 chunks +4 lines, -79 lines 0 comments Download
M media/base/yuv_convert_unittest.cc View 1 2 6 chunks +4 lines, -155 lines 0 comments Download
M media/media.gyp View 1 3 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + dalecurtis@chromium.org, rileya@chromium.org
6 years, 3 months ago (2014-08-28 00:00:14 UTC) #1
Lei Zhang
Let's have another go at it. See the difference between the patch sets for what ...
6 years, 3 months ago (2014-08-28 00:00:14 UTC) #2
DaleCurtis
lgtm
6 years, 3 months ago (2014-08-28 00:19:03 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-28 00:21:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/516543004/40001
6 years, 3 months ago (2014-08-28 00:27:51 UTC) #5
rileya (GONE FROM CHROMIUM)
lgtm
6 years, 3 months ago (2014-08-28 00:35:43 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 02:03:56 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 38f9b9bb98a08eace1386c4c16df57be0aa1488e
6 years, 3 months ago (2014-08-28 02:12:11 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:31 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a5fa6d9c5e117a1ae09014f71245cc62a35936cf
Cr-Commit-Position: refs/heads/master@{#292294}

Powered by Google App Engine
This is Rietveld 408576698