Cleanup: Remove unneeded media/ SSE2 checks and unused code. (try 2)

media/base/yuv_convert_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/base_paths.h"
 #include "base/cpu.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "media/base/djb2.h"
@@ skipping 639 matching lines @@
     int diff = yuv_reference_bytes[i] - yuv_converted_bytes[i];
     if (diff < 0)
       diff = -diff;
     error += diff;
   }
 
   // Make sure there's no difference from the reference.
   EXPECT_EQ(0, error);
 }
 
-TEST(YUVConvertTest, ConvertYUVToRGB32Row_MMX) {
-  base::CPU cpu;
-  if (!cpu.has_mmx()) {
-    LOG(WARNING) << "System not supported. Test skipped.";
-    return;
-  }
-
-  scoped_ptr<uint8[]> yuv_bytes(new uint8[kYUV12Size]);
-  scoped_ptr<uint8[]> rgb_bytes_reference(new uint8[kRGBSize]);
-  scoped_ptr<uint8[]> rgb_bytes_converted(new uint8[kRGBSize]);
-  ReadYV12Data(&yuv_bytes);
-
-  const int kWidth = 167;
-  ConvertYUVToRGB32Row_C(yuv_bytes.get(),
-                         yuv_bytes.get() + kSourceUOffset,
-                         yuv_bytes.get() + kSourceVOffset,
-                         rgb_bytes_reference.get(),
-                         kWidth,
-                         GetLookupTable(YV12));
-  ConvertYUVToRGB32Row_MMX(yuv_bytes.get(),
-                           yuv_bytes.get() + kSourceUOffset,
-                           yuv_bytes.get() + kSourceVOffset,
-                           rgb_bytes_converted.get(),
-                           kWidth,
-                           GetLookupTable(YV12));
-  media::EmptyRegisterState();
-  EXPECT_EQ(0, memcmp(rgb_bytes_reference.get(),
-                      rgb_bytes_converted.get(),
-                      kWidth * kBpp));
-}
-
 TEST(YUVConvertTest, ConvertYUVToRGB32Row_SSE) {
   base::CPU cpu;
   if (!cpu.has_sse()) {
     LOG(WARNING) << "System not supported. Test skipped.";
     return;
   }
 
   scoped_ptr<uint8[]> yuv_bytes(new uint8[kYUV12Size]);
   scoped_ptr<uint8[]> rgb_bytes_reference(new uint8[kRGBSize]);
   scoped_ptr<uint8[]> rgb_bytes_converted(new uint8[kRGBSize]);
@@ skipping 11 matching lines @@
                            yuv_bytes.get() + kSourceVOffset,
                            rgb_bytes_converted.get(),
                            kWidth,
                            GetLookupTable(YV12));
   media::EmptyRegisterState();
   EXPECT_EQ(0, memcmp(rgb_bytes_reference.get(),
                       rgb_bytes_converted.get(),
                       kWidth * kBpp));
 }
 
-TEST(YUVConvertTest, ScaleYUVToRGB32Row_MMX) {
-  base::CPU cpu;
-  if (!cpu.has_mmx()) {
-    LOG(WARNING) << "System not supported. Test skipped.";
-    return;
-  }
-
-  scoped_ptr<uint8[]> yuv_bytes(new uint8[kYUV12Size]);
-  scoped_ptr<uint8[]> rgb_bytes_reference(new uint8[kRGBSize]);
-  scoped_ptr<uint8[]> rgb_bytes_converted(new uint8[kRGBSize]);
-  ReadYV12Data(&yuv_bytes);
-
-  const int kWidth = 167;
-  const int kSourceDx = 80000;  // This value means a scale down.
-  ScaleYUVToRGB32Row_C(yuv_bytes.get(),
-                       yuv_bytes.get() + kSourceUOffset,
-                       yuv_bytes.get() + kSourceVOffset,
-                       rgb_bytes_reference.get(),
-                       kWidth,
-                       kSourceDx,
-                       GetLookupTable(YV12));
-  ScaleYUVToRGB32Row_MMX(yuv_bytes.get(),
-                         yuv_bytes.get() + kSourceUOffset,
-                         yuv_bytes.get() + kSourceVOffset,
-                         rgb_bytes_converted.get(),
-                         kWidth,
-                         kSourceDx,
-                         GetLookupTable(YV12));
-  media::EmptyRegisterState();
-  EXPECT_EQ(0, memcmp(rgb_bytes_reference.get(),
-                      rgb_bytes_converted.get(),
-                      kWidth * kBpp));
-}
-
+// 64-bit release + component builds on Windows are too smart and optimizes
+// away the function being tested.
+#if defined(OS_WIN) && (defined(ARCH_CPU_X86) || !defined(COMPONENT_BUILD))
 TEST(YUVConvertTest, ScaleYUVToRGB32Row_SSE) {
   base::CPU cpu;
   if (!cpu.has_sse()) {
     LOG(WARNING) << "System not supported. Test skipped.";
     return;
   }
 
   scoped_ptr<uint8[]> yuv_bytes(new uint8[kYUV12Size]);
   scoped_ptr<uint8[]> rgb_bytes_reference(new uint8[kRGBSize]);
   scoped_ptr<uint8[]> rgb_bytes_converted(new uint8[kRGBSize]);
@@ skipping 14 matching lines @@
                          rgb_bytes_converted.get(),
                          kWidth,
                          kSourceDx,
                          GetLookupTable(YV12));
   media::EmptyRegisterState();
   EXPECT_EQ(0, memcmp(rgb_bytes_reference.get(),
                       rgb_bytes_converted.get(),
                       kWidth * kBpp));
 }
 
-TEST(YUVConvertTest, LinearScaleYUVToRGB32Row_MMX) {
-  base::CPU cpu;
-  if (!cpu.has_mmx()) {
-    LOG(WARNING) << "System not supported. Test skipped.";
-    return;
-  }
-
-  scoped_ptr<uint8[]> yuv_bytes(new uint8[kYUV12Size]);
-  scoped_ptr<uint8[]> rgb_bytes_reference(new uint8[kRGBSize]);
-  scoped_ptr<uint8[]> rgb_bytes_converted(new uint8[kRGBSize]);
-  ReadYV12Data(&yuv_bytes);
-
-  const int kWidth = 167;
-  const int kSourceDx = 80000;  // This value means a scale down.
-  LinearScaleYUVToRGB32Row_C(yuv_bytes.get(),
-                             yuv_bytes.get() + kSourceUOffset,
-                             yuv_bytes.get() + kSourceVOffset,
-                             rgb_bytes_reference.get(),
-                             kWidth,
-                             kSourceDx,
-                             GetLookupTable(YV12));
-  LinearScaleYUVToRGB32Row_MMX(yuv_bytes.get(),
-                               yuv_bytes.get() + kSourceUOffset,
-                               yuv_bytes.get() + kSourceVOffset,
-                               rgb_bytes_converted.get(),
-                               kWidth,
-                               kSourceDx,
-                               GetLookupTable(YV12));
-  media::EmptyRegisterState();
-  EXPECT_EQ(0, memcmp(rgb_bytes_reference.get(),
-                      rgb_bytes_converted.get(),
-                      kWidth * kBpp));
-}
-
 TEST(YUVConvertTest, LinearScaleYUVToRGB32Row_SSE) {
   base::CPU cpu;
   if (!cpu.has_sse()) {
     LOG(WARNING) << "System not supported. Test skipped.";
     return;
   }
 
   scoped_ptr<uint8[]> yuv_bytes(new uint8[kYUV12Size]);
   scoped_ptr<uint8[]> rgb_bytes_reference(new uint8[kRGBSize]);
   scoped_ptr<uint8[]> rgb_bytes_converted(new uint8[kRGBSize]);
@@ skipping 13 matching lines @@
                                yuv_bytes.get() + kSourceVOffset,
                                rgb_bytes_converted.get(),
                                kWidth,
                                kSourceDx,
                                GetLookupTable(YV12));
   media::EmptyRegisterState();
   EXPECT_EQ(0, memcmp(rgb_bytes_reference.get(),
                       rgb_bytes_converted.get(),
                       kWidth * kBpp));
 }
+#endif  // defined(OS_WIN) && (ARCH_CPU_X86 || COMPONENT_BUILD)
 
 TEST(YUVConvertTest, FilterYUVRows_C_OutOfBounds) {
   scoped_ptr<uint8[]> src(new uint8[16]);
   scoped_ptr<uint8[]> dst(new uint8[16]);
 
   memset(src.get(), 0xff, 16);
   memset(dst.get(), 0, 16);
 
   media::FilterYUVRows_C(dst.get(), src.get(), src.get(), 1, 255);
 
   EXPECT_EQ(255u, dst[0]);
   for (int i = 1; i < 16; ++i) {
     EXPECT_EQ(0u, dst[i]) << " not equal at " << i;
   }
 }
 
-#if defined(MEDIA_MMX_INTRINSICS_AVAILABLE)
-TEST(YUVConvertTest, FilterYUVRows_MMX_OutOfBounds) {
-  base::CPU cpu;
-  if (!cpu.has_mmx()) {
-    LOG(WARNING) << "System not supported. Test skipped.";
-    return;
-  }
-
-  scoped_ptr<uint8[]> src(new uint8[16]);
-  scoped_ptr<uint8[]> dst(new uint8[16]);
-
-  memset(src.get(), 0xff, 16);
-  memset(dst.get(), 0, 16);
-
-  media::FilterYUVRows_MMX(dst.get(), src.get(), src.get(), 1, 255);
-  media::EmptyRegisterState();
-
-  EXPECT_EQ(255u, dst[0]);
-  for (int i = 1; i < 16; ++i) {
-    EXPECT_EQ(0u, dst[i]);
-  }
-}
-#endif  // defined(MEDIA_MMX_INTRINSICS_AVAILABLE)
-
 TEST(YUVConvertTest, FilterYUVRows_SSE2_OutOfBounds) {
   base::CPU cpu;
   if (!cpu.has_sse2()) {
     LOG(WARNING) << "System not supported. Test skipped.";
     return;
   }
 
   scoped_ptr<uint8[]> src(new uint8[16]);
   scoped_ptr<uint8[]> dst(new uint8[16]);
 
   memset(src.get(), 0xff, 16);
   memset(dst.get(), 0, 16);
 
   media::FilterYUVRows_SSE2(dst.get(), src.get(), src.get(), 1, 255);
 
   EXPECT_EQ(255u, dst[0]);
   for (int i = 1; i < 16; ++i) {
     EXPECT_EQ(0u, dst[i]);
   }
 }
 
-#if defined(MEDIA_MMX_INTRINSICS_AVAILABLE)
-TEST(YUVConvertTest, FilterYUVRows_MMX_UnalignedDestination) {
-  base::CPU cpu;
-  if (!cpu.has_mmx()) {
-    LOG(WARNING) << "System not supported. Test skipped.";
-    return;
-  }
-
-  const int kSize = 32;
-  scoped_ptr<uint8[]> src(new uint8[kSize]);
-  scoped_ptr<uint8[]> dst_sample(new uint8[kSize]);
-  scoped_ptr<uint8[]> dst(new uint8[kSize]);
-
-  memset(dst_sample.get(), 0, kSize);
-  memset(dst.get(), 0, kSize);
-  for (int i = 0; i < kSize; ++i)
-    src[i] = 100 + i;
-
-  media::FilterYUVRows_C(dst_sample.get(),
-                         src.get(), src.get(), 17, 128);
-
-  // Generate an unaligned output address.
-  uint8* dst_ptr =
-      reinterpret_cast<uint8*>(
-          (reinterpret_cast<uintptr_t>(dst.get() + 8) & ~7) + 1);
-  media::FilterYUVRows_MMX(dst_ptr, src.get(), src.get(), 17, 128);
-  media::EmptyRegisterState();
-
-  EXPECT_EQ(0, memcmp(dst_sample.get(), dst_ptr, 17));
-}
-#endif  // defined(MEDIA_MMX_INTRINSICS_AVAILABLE)
-
 TEST(YUVConvertTest, FilterYUVRows_SSE2_UnalignedDestination) {
   base::CPU cpu;
   if (!cpu.has_sse2()) {
     LOG(WARNING) << "System not supported. Test skipped.";
     return;
   }
 
   const int kSize = 64;
   scoped_ptr<uint8[]> src(new uint8[kSize]);
   scoped_ptr<uint8[]> dst_sample(new uint8[kSize]);
@@ skipping 73 matching lines @@
   EXPECT_EQ(0, memcmp(rgb_bytes_reference.get(),
                       rgb_bytes_converted.get(),
                       kWidth * kBpp));
 }
 
 #endif  // defined(ARCH_CPU_X86_64)
 
 #endif  // defined(ARCH_CPU_X86_FAMILY)
 
 }  // namespace media