Stop devtools if socket for http server cannot be instantiated.

Stop devtools if socket for http server cannot be instantiated.

Currently, it crashes entire chrome. This CL is to stop devtools gracefully
when socket for http server cannot be instantiated because of any reasons
including address-already-in-use error.

BUG=407999
Committed: https://crrev.com/d0d6d20257baefd4e018d7d2f9273d5357186c8f
Cr-Commit-Position: refs/heads/master@{#292341}

[byungchul, 2014-08-27 17:23:50]

byungchul@chromium.org changed reviewers:
+ mnaganov@chromium.org, pfeldman@chromium.org, yurys@chromium.org

[byungchul, 2014-08-27 17:25:07]

@Yury, could you please review this CL while Pavel is OOO.

[pfeldman, 2014-08-27 18:41:21]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org, vkuzkokov@chromium.org

[dgozman, 2014-08-27 19:32:24]

https://codereview.chromium.org/516483002/diff/1/content/browser/devtools/dev...
File content/browser/devtools/devtools_http_handler_impl.cc (right):

https://codereview.chromium.org/516483002/diff/1/content/browser/devtools/dev...
content/browser/devtools/devtools_http_handler_impl.cc:257: if
(server_->GetLocalAddress(&ip_address))
Please guard this, since you can have no |server_| now.

if (server_ && server_->GetLocalAddress(&ip_address))

https://codereview.chromium.org/516483002/diff/1/content/browser/devtools/dev...
content/browser/devtools/devtools_http_handler_impl.cc:707:
base::Bind(&DevToolsHttpHandlerImpl::Stop, this));
This call will destroy this object, and later call to Stop() should fail. See
ResetHandlerThreadAndRelease.
You should |StopHandlerThread| on FILE and |ResetHandlerThread| on UI after
that.

[byungchul, 2014-08-27 20:45:37]

https://codereview.chromium.org/516483002/diff/1/content/browser/devtools/dev...
File content/browser/devtools/devtools_http_handler_impl.cc (right):

https://codereview.chromium.org/516483002/diff/1/content/browser/devtools/dev...
content/browser/devtools/devtools_http_handler_impl.cc:257: if
(server_->GetLocalAddress(&ip_address))
On 2014/08/27 19:32:23, dgozman wrote:
> Please guard this, since you can have no |server_| now.
> 
> if (server_ && server_->GetLocalAddress(&ip_address))

Done.

https://codereview.chromium.org/516483002/diff/1/content/browser/devtools/dev...
content/browser/devtools/devtools_http_handler_impl.cc:707:
base::Bind(&DevToolsHttpHandlerImpl::Stop, this));
On 2014/08/27 19:32:24, dgozman wrote:
> This call will destroy this object, and later call to Stop() should fail. See
> ResetHandlerThreadAndRelease.
> You should |StopHandlerThread| on FILE and |ResetHandlerThread| on UI after
> that.

Done.

[dgozman, 2014-08-28 05:11:28]

lgtm

[byungchul, 2014-08-28 05:39:37]

The CQ bit was checked by byungchul@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:40:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/byungchul@chromium.org/516483002/20001

[commit-bot: I haz the power, 2014-08-28 06:19:37]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-28 06:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 06:23:49]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2014-08-28 06:56:33]

lgtm

[byungchul, 2014-08-28 07:21:23]

The CQ bit was checked by byungchul@chromium.org

[commit-bot: I haz the power, 2014-08-28 07:22:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/byungchul@chromium.org/516483002/20001

[commit-bot: I haz the power, 2014-08-28 07:27:34]

Committed patchset #2 (id:20001) as ba72d8abbe5974ce51b4c0341431429f99819533

[commit-bot: I haz the power, 2014-09-10 02:58:14]

Patchset 2 (id:??) landed as
https://crrev.com/d0d6d20257baefd4e018d7d2f9273d5357186c8f
Cr-Commit-Position: refs/heads/master@{#292341}