Stop devtools if socket for http server cannot be instantiated.

content/browser/devtools/devtools_http_handler_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/devtools_http_handler_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 236 matching lines @@
   if (!thread_)
     return;
   BrowserThread::PostTaskAndReply(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&DevToolsHttpHandlerImpl::StopHandlerThread, this),
       base::Bind(&DevToolsHttpHandlerImpl::ResetHandlerThreadAndRelease, this));
 }
 
 GURL DevToolsHttpHandlerImpl::GetFrontendURL() {
   net::IPEndPoint ip_address;
   if (server_->GetLocalAddress(&ip_address))

[dgozman, 2014/08/27 19:32:23]

Please guard this, since you can have no |server_| now.

if (server_ && server_->GetLocalAddress(&ip_address))

[byungchul, 2014/08/27 20:45:37]

Done.

     return GURL();
   return GURL(std::string("http://") + ip_address.ToString() + frontend_url_);
 }
 
 static std::string PathWithoutParams(const std::string& path) {
   size_t query_position = path.find("?");
   if (query_position != std::string::npos)
     return path.substr(0, query_position);
   return path;
 }
@@ skipping 424 matching lines @@
       active_port_output_directory_(active_port_output_directory) {
   if (frontend_url_.empty())
     frontend_url_ = "/devtools/devtools.html";
 
   // Balanced in ResetHandlerThreadAndRelease().
   AddRef();
 }
 
 // Runs on the handler thread
 void DevToolsHttpHandlerImpl::Init() {
-  server_.reset(new net::HttpServer(server_socket_factory_->CreateAndListen(),
-                                    this));
+  scoped_ptr<net::ServerSocket> server_socket =
+      server_socket_factory_->CreateAndListen();
+  if (!server_socket) {
+    LOG(ERROR) << "Cannot start http server for devtools. Stop devtools.";
+    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE,
+                            base::Bind(&DevToolsHttpHandlerImpl::Stop, this));

[dgozman, 2014/08/27 19:32:24]

This call will destroy this object, and later call to Stop() should fail. See
ResetHandlerThreadAndRelease.
You should |StopHandlerThread| on FILE and |ResetHandlerThread| on UI after
that.

[byungchul, 2014/08/27 20:45:36]

Done.

+    return;
+  }
+
+  server_.reset(new net::HttpServer(server_socket.Pass(), this));
   if (!active_port_output_directory_.empty())
     WriteActivePortToUserProfile();
 }
 
 // Runs on the handler thread
 void DevToolsHttpHandlerImpl::Teardown() {
   server_.reset(NULL);
 }
 
 // Runs on FILE thread to make sure that it is serialized against
@@ skipping 148 matching lines @@
         id.c_str(),
         host);
     dictionary->SetString(
         kTargetDevtoolsFrontendUrlField, devtools_frontend_url);
   }
 
   return dictionary;
 }
 
 }  // namespace content