Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 516453002: Fix leak of MultiThreadedCertVerifier in ProfileIOData. (Closed)

Created:
6 years, 3 months ago by pneubeck (no reviews)
Modified:
6 years, 3 months ago
Reviewers:
mmenke, mattm
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix leak of MultiThreadedCertVerifier in ProfileIOData. Heap allocated MultiThreadedCertVerifier was passed to URLRequestContext::set_cert_verifier, which doesn't take ownership. Leak was introduced in r249928. BUG=NONE Committed: https://crrev.com/0d227dd16369e6712e50c77b41b754ba9f78153a Cr-Commit-Position: refs/heads/master@{#292342}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Clarified comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -9 lines) Patch
M chrome/browser/profiles/profile_io_data.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 4 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
pneubeck (no reviews)
Patchset #1 (id:1) has been deleted
6 years, 3 months ago (2014-08-27 15:05:07 UTC) #1
pneubeck (no reviews)
Patchset #2 (id:40001) has been deleted
6 years, 3 months ago (2014-08-27 15:06:40 UTC) #2
pneubeck (no reviews)
Patchset #1 (id:20001) has been deleted
6 years, 3 months ago (2014-08-27 15:06:45 UTC) #3
pneubeck (no reviews)
pneubeck@chromium.org changed reviewers: + mattm@chromium.org, mmenke@chromium.org
6 years, 3 months ago (2014-08-27 15:09:56 UTC) #4
pneubeck (no reviews)
@mmenke, please owner-review.
6 years, 3 months ago (2014-08-27 15:09:56 UTC) #5
mattm
lgtm with suggestion https://codereview.chromium.org/516453002/diff/60001/chrome/browser/profiles/profile_io_data.h File chrome/browser/profiles/profile_io_data.h (right): https://codereview.chromium.org/516453002/diff/60001/chrome/browser/profiles/profile_io_data.h#newcode591 chrome/browser/profiles/profile_io_data.h:591: // Set if a PolicyCertVerifier is ...
6 years, 3 months ago (2014-08-27 18:50:28 UTC) #6
mmenke
LGTM
6 years, 3 months ago (2014-08-27 19:09:32 UTC) #7
pneubeck (no reviews)
The CQ bit was checked by pneubeck@chromium.org
6 years, 3 months ago (2014-08-28 06:31:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/516453002/80001
6 years, 3 months ago (2014-08-28 06:32:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:80001) as cef5ed9ad0affcac039c52760e1774f656711de7
6 years, 3 months ago (2014-08-28 07:28:25 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:58:16 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0d227dd16369e6712e50c77b41b754ba9f78153a
Cr-Commit-Position: refs/heads/master@{#292342}

Powered by Google App Engine
This is Rietveld 408576698