Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Side by Side Diff: chrome/browser/profiles/profile_io_data.h

Issue 516453002: Fix leak of MultiThreadedCertVerifier in ProfileIOData. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_ 5 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
6 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_ 6 #define CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 29 matching lines...) Expand all
40 class MediaDeviceIDSalt; 40 class MediaDeviceIDSalt;
41 class ProtocolHandlerRegistry; 41 class ProtocolHandlerRegistry;
42 class SigninNamesOnIOThread; 42 class SigninNamesOnIOThread;
43 class SupervisedUserURLFilter; 43 class SupervisedUserURLFilter;
44 44
45 namespace extensions { 45 namespace extensions {
46 class InfoMap; 46 class InfoMap;
47 } 47 }
48 48
49 namespace net { 49 namespace net {
50 class CertVerifier;
50 class ChannelIDService; 51 class ChannelIDService;
51 class CookieStore; 52 class CookieStore;
52 class FraudulentCertificateReporter; 53 class FraudulentCertificateReporter;
53 class FtpTransactionFactory; 54 class FtpTransactionFactory;
54 class HttpServerProperties; 55 class HttpServerProperties;
55 class HttpTransactionFactory; 56 class HttpTransactionFactory;
56 class ProxyConfigService; 57 class ProxyConfigService;
57 class ProxyService; 58 class ProxyService;
58 class SSLConfigService; 59 class SSLConfigService;
59 class TransportSecurityPersister; 60 class TransportSecurityPersister;
(...skipping 520 matching lines...) Expand 10 before | Expand all | Expand 10 after
580 #endif 581 #endif
581 mutable scoped_ptr<net::ChannelIDService> channel_id_service_; 582 mutable scoped_ptr<net::ChannelIDService> channel_id_service_;
582 mutable scoped_ptr<ChromeNetworkDelegate> network_delegate_; 583 mutable scoped_ptr<ChromeNetworkDelegate> network_delegate_;
583 mutable scoped_ptr<net::FraudulentCertificateReporter> 584 mutable scoped_ptr<net::FraudulentCertificateReporter>
584 fraudulent_certificate_reporter_; 585 fraudulent_certificate_reporter_;
585 mutable scoped_ptr<net::ProxyService> proxy_service_; 586 mutable scoped_ptr<net::ProxyService> proxy_service_;
586 mutable scoped_ptr<net::TransportSecurityState> transport_security_state_; 587 mutable scoped_ptr<net::TransportSecurityState> transport_security_state_;
587 mutable scoped_ptr<net::HttpServerProperties> 588 mutable scoped_ptr<net::HttpServerProperties>
588 http_server_properties_; 589 http_server_properties_;
589 #if defined(OS_CHROMEOS) 590 #if defined(OS_CHROMEOS)
590 mutable scoped_ptr<policy::PolicyCertVerifier> cert_verifier_; 591 // Set if a PolicyCertVerifier is used. Owned by |cert_verifier_|.
mattm 2014/08/27 18:50:28 Maybe add / clarify comment that cert_verifier_ wi
592 mutable policy::PolicyCertVerifier* policy_cert_verifier_;
593 mutable scoped_ptr<net::CertVerifier> cert_verifier_;
591 mutable std::string username_hash_; 594 mutable std::string username_hash_;
592 mutable bool use_system_key_slot_; 595 mutable bool use_system_key_slot_;
593 #endif 596 #endif
594 597
595 mutable scoped_ptr<net::TransportSecurityPersister> 598 mutable scoped_ptr<net::TransportSecurityPersister>
596 transport_security_persister_; 599 transport_security_persister_;
597 600
598 // These are only valid in between LazyInitialize() and their accessor being 601 // These are only valid in between LazyInitialize() and their accessor being
599 // called. 602 // called.
600 mutable scoped_ptr<net::URLRequestContext> main_request_context_; 603 mutable scoped_ptr<net::URLRequestContext> main_request_context_;
(...skipping 20 matching lines...) Expand all
621 624
622 // TODO(jhawkins): Remove once crbug.com/102004 is fixed. 625 // TODO(jhawkins): Remove once crbug.com/102004 is fixed.
623 bool initialized_on_UI_thread_; 626 bool initialized_on_UI_thread_;
624 627
625 const Profile::ProfileType profile_type_; 628 const Profile::ProfileType profile_type_;
626 629
627 DISALLOW_COPY_AND_ASSIGN(ProfileIOData); 630 DISALLOW_COPY_AND_ASSIGN(ProfileIOData);
628 }; 631 };
629 632
630 #endif // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_ 633 #endif // CHROME_BROWSER_PROFILES_PROFILE_IO_DATA_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/profiles/profile_io_data.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698