Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Unified Diff: media/base/android/media_player_manager.h

Issue 51613002: Abort MSP::OnPrefetchDone() if just after MSP::Release(). Let seek and config change survive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add more unit test coverage Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/media_player_manager.h
diff --git a/media/base/android/media_player_manager.h b/media/base/android/media_player_manager.h
index 668613bf5ac879ed52737dea51f17d9551a48ab1..2746f4d1111f2bca4732a05906f14c589bdbed35 100644
--- a/media/base/android/media_player_manager.h
+++ b/media/base/android/media_player_manager.h
@@ -106,6 +106,9 @@ class MEDIA_EXPORT MediaPlayerManager {
const std::string& session_id,
const std::vector<uint8>& message,
const std::string& destination_url) = 0;
+
+ // Test-only method to hook completion of decode cycles in MediaSourcePlayer.
+ virtual void OnMediaDecoderCallbackForTesting() = 0;
acolwell GONE FROM CHROMIUM 2013/10/30 23:29:53 This does not seem right. Why don't you just put a
wolenetz 2013/10/31 01:39:11 Thanks for catching this. Putting this in MSP simp
};
} // namespace media

Powered by Google App Engine
This is Rietveld 408576698