media/base/android/media_source_player.h - Issue 51613002: Abort MSP::OnPrefetchDone() if just after MSP::Release(). Let seek and config change survive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_source_player.h

Issue 51613002: Abort MSP::OnPrefetchDone() if just after MSP::Release(). Let seek and config change survive. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add more unit test coverage Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_player_manager.h ('K') | « media/base/android/media_player_manager.h ('k') | media/base/android/media_source_player.cc » ('j') | media/base/android/media_source_player.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_source_player.h

diff --git a/media/base/android/media_source_player.h b/media/base/android/media_source_player.h

index 3c16689f7ddd43869f244fde0207e24c693ca3fd..c3bf9b9a4dc562105a2f0373c425ffdb965063aa 100644

--- a/media/base/android/media_source_player.h

+++ b/media/base/android/media_source_player.h

@@ -154,6 +154,9 @@ class MEDIA_EXPORT MediaSourcePlayer : public MediaPlayerAndroid,

// resync with audio and starts decoding.

void OnPrefetchDone();

+ // TODO(qinmin/wolenetz): Reorder these based on their priority from

+ // ProcessPendingEvents(). Release() and other routines are dependent upon

+ // priority consistency.

enum PendingEventFlags {

NO_EVENT_PENDING = 0,

SEEK_EVENT_PENDING = 1 << 0,