Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 516103003: scheduler: Tell the scheduler about frame timing (Closed)

Created:
6 years, 3 months ago by Sami
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, mithro-old
Project:
blink
Visibility:
Public.

Description

scheduler: Tell the scheduler about frame timing This patch routes information about the current frame start time, the deadline by which rendering should finish and the expected interval between frames to the Blink scheduler. This information will be used to schedule lower priority and idle tasks so that they do not preempt input processing or painting. BUG=391005 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181253

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Still need to keep animate() around. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -7 lines) Patch
M Source/platform/scheduler/Scheduler.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M Source/platform/scheduler/Scheduler.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 4 chunks +13 lines, -5 lines 0 comments Download
M public/web/WebBeginFrameArgs.h View 2 chunks +15 lines, -0 lines 0 comments Download
M public/web/WebWidget.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sami
skyostil@chromium.org changed reviewers: + alexclarke@chromium.org, eseidel@chromium.org, picksi@chromium.org
6 years, 3 months ago (2014-08-29 11:51:25 UTC) #1
Sami
Chrome patch here: https://codereview.chromium.org/521613002
6 years, 3 months ago (2014-08-29 11:51:51 UTC) #2
eseidel
lgtm
6 years, 3 months ago (2014-09-02 16:12:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/516103003/20001
6 years, 3 months ago (2014-09-02 17:53:12 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 3 months ago (2014-09-02 18:11:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/49128)
6 years, 3 months ago (2014-09-02 18:18:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/516103003/40001
6 years, 3 months ago (2014-09-02 18:38:33 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-02 19:39:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 181253

Powered by Google App Engine
This is Rietveld 408576698