Manual fixups in gpu/ for scoped_refptr operator T* removal.

Manual fixups in gpu/ for scoped_refptr operator T* removal.

BUG=110610
TBR=sievers@chromium.org

Committed: https://crrev.com/6ef3c55508e568e191db4fbbd848b83fd445d7ab
Cr-Commit-Position: refs/heads/master@{#292777}

[dcheng, 2014-08-28 17:39:39]

dcheng@chromium.org changed reviewers:
+ jbauman@chromium.org

[dcheng, 2014-08-28 17:39:39]

Manual fixups in gpu for cases the automated tool opted to skip.

I've converted a constructor to take const scoped_refptr<T>& since many callers
are already passing a scoped_refptr--it's a bit roundabout to turn that into a
raw pointer, and then turn the raw pointer into a scoped_refptr again.

This does have implications for other modules. Files that try to pass NULL for
the optional arguments will need to #include those module for that refcounted
object, since they will need to construct a temporary scoped_refptr<> to wrap
the NULL pointer. I haven't included those in this patch, because when I was
working on the original megapatch, I moved those includes to the header. I'll
send a separate patch that includes those (it was hard to include those in the
megapatch, because there were so many manual fixups still)

[jbauman, 2014-08-28 18:49:11]

lgtm assuming you can fix it to compile.

[dcheng, 2014-08-28 23:00:59]

On 2014/08/28 at 18:49:11, jbauman wrote:
> lgtm assuming you can fix it to compile.

PTAL. I had to make some changes to ContextGroup to fix the build, as well as
add includes for files that try to pass NULL as the MailboxManager or
MemoryTracking. Since the argument is a const scoped_refptr<T>& now, this
constructs a temporary scoped_refptr to wrap the NULL pointer--but this requires
the full definition of MailboxManager/MemoryTracking.

[jbauman, 2014-08-29 20:24:34]

lgtm

[dcheng, 2014-08-29 21:35:54]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-30 00:54:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-30 00:59:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-30 00:59:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dcheng, 2014-08-30 04:55:48]

dcheng@chromium.org changed reviewers:
+ sievers@chromium.org

[dcheng, 2014-08-30 04:56:08]

TBRing sievers@chromium.org for the gpu/gles2_conform_support/egl/display.cc
changes.

[dcheng, 2014-08-30 04:56:11]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-30 04:57:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/515943002/40001

[commit-bot: I haz the power, 2014-08-30 05:35:19]

Committed patchset #3 (id:40001) as ef0d65ab5d6b1ea9157727b7925dd689a9e0e24e

[commit-bot: I haz the power, 2014-09-10 03:13:53]

Patchset 3 (id:??) landed as
https://crrev.com/6ef3c55508e568e191db4fbbd848b83fd445d7ab
Cr-Commit-Position: refs/heads/master@{#292777}