Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 515813002: Regenerate the long-lived test certificates to use SHA-256 (Closed)

Created:
6 years, 3 months ago by Ryan Sleevi
Modified:
6 years, 2 months ago
Reviewers:
mattm
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_cert_scripts_2
Project:
chromium
Visibility:
Public.

Description

Regenerate the long-lived test certificates to use SHA-256 BUG=401365 Committed: https://crrev.com/80daaf71e46826d627cbf97fe28ce50ceb46a827 Cr-Commit-Position: refs/heads/master@{#297061}

Patch Set 1 #

Patch Set 2 : Accidental CL ordering #

Total comments: 1

Patch Set 3 : Nuke name_constraint_ok.crt #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3461 lines, -3151 lines) Patch
M chrome/common/net/x509_certificate_model_unittest.cc View 5 chunks +40 lines, -40 lines 0 comments Download
M net/cert/cert_verify_proc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 1 2 3 6 chunks +16 lines, -59 lines 0 comments Download
M net/cert/nss_cert_database_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +35 lines, -36 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +45 lines, -45 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-768-rsa-intermediate.pem View 1 chunk +33 lines, -33 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +29 lines, -29 lines 0 comments Download
M net/data/ssl/certificates/1024-rsa-intermediate.pem View 1 chunk +46 lines, -46 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +47 lines, -47 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +57 lines, -57 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-768-rsa-intermediate.pem View 1 chunk +45 lines, -45 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +41 lines, -41 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-intermediate.pem View 1 chunk +58 lines, -58 lines 0 comments Download
M net/data/ssl/certificates/2048-rsa-root.pem View 1 chunk +73 lines, -15 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +33 lines, -33 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +42 lines, -42 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-768-rsa-intermediate.pem View 1 chunk +30 lines, -30 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +27 lines, -27 lines 0 comments Download
M net/data/ssl/certificates/768-rsa-intermediate.pem View 1 chunk +43 lines, -43 lines 0 comments Download
M net/data/ssl/certificates/aia-cert.pem View 2 chunks +55 lines, -55 lines 0 comments Download
M net/data/ssl/certificates/aia-intermediate.der View Binary file 0 comments Download
M net/data/ssl/certificates/aia-root.pem View 2 chunks +51 lines, -51 lines 0 comments Download
M net/data/ssl/certificates/client_1.key View 1 chunk +25 lines, -25 lines 0 comments Download
M net/data/ssl/certificates/client_1.pem View 1 chunk +54 lines, -54 lines 0 comments Download
M net/data/ssl/certificates/client_1.pk8 View Binary file 0 comments Download
M net/data/ssl/certificates/client_1_ca.pem View 1 chunk +53 lines, -53 lines 0 comments Download
M net/data/ssl/certificates/client_2.key View 1 chunk +25 lines, -25 lines 0 comments Download
M net/data/ssl/certificates/client_2.pem View 1 chunk +54 lines, -54 lines 0 comments Download
M net/data/ssl/certificates/client_2.pk8 View Binary file 0 comments Download
M net/data/ssl/certificates/client_2_ca.pem View 1 chunk +53 lines, -53 lines 0 comments Download
M net/data/ssl/certificates/crit-codeSigning-chain.pem View 2 chunks +82 lines, -82 lines 0 comments Download
A net/data/ssl/certificates/crlset_by_intermediate_serial.raw View Binary file 0 comments Download
A net/data/ssl/certificates/crlset_by_leaf_spki.raw View Binary file 0 comments Download
A net/data/ssl/certificates/crlset_by_root_serial.raw View Binary file 0 comments Download
M net/data/ssl/certificates/duplicate_cn_1.p12 View Binary file 0 comments Download
M net/data/ssl/certificates/duplicate_cn_1.pem View 1 chunk +57 lines, -57 lines 0 comments Download
M net/data/ssl/certificates/duplicate_cn_2.p12 View Binary file 0 comments Download
M net/data/ssl/certificates/duplicate_cn_2.pem View 1 chunk +57 lines, -57 lines 0 comments Download
M net/data/ssl/certificates/eku-test-root.pem View 1 chunk +61 lines, -52 lines 0 comments Download
M net/data/ssl/certificates/expired_cert.pem View 2 chunks +83 lines, -83 lines 0 comments Download
M net/data/ssl/certificates/explicit-policy-chain.pem View 4 chunks +161 lines, -161 lines 0 comments Download
M net/data/ssl/certificates/multi-root-chain1.pem View 1 chunk +240 lines, -240 lines 0 comments Download
M net/data/ssl/certificates/multi-root-chain2.pem View 1 chunk +240 lines, -240 lines 0 comments Download
D net/data/ssl/certificates/name_constraint_bad.crt View 1 chunk +0 lines, -109 lines 0 comments Download
A net/data/ssl/certificates/name_constraint_bad.pem View 1 chunk +109 lines, -0 lines 0 comments Download
A net/data/ssl/certificates/name_constraint_good.pem View 1 chunk +109 lines, -0 lines 0 comments Download
D net/data/ssl/certificates/name_constraint_ok.crt View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
M net/data/ssl/certificates/non-crit-codeSigning-chain.pem View 2 chunks +82 lines, -82 lines 0 comments Download
M net/data/ssl/certificates/ok_cert.pem View 1 chunk +85 lines, -85 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-1024-rsa-intermediate.pem View 1 chunk +29 lines, -29 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-2048-rsa-intermediate.pem View 1 chunk +39 lines, -39 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-768-rsa-intermediate.pem View 1 chunk +26 lines, -26 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-ee-by-prime256v1-ecdsa-intermediate.pem View 1 chunk +23 lines, -23 lines 0 comments Download
M net/data/ssl/certificates/prime256v1-ecdsa-intermediate.pem View 1 chunk +40 lines, -40 lines 0 comments Download
D net/data/ssl/certificates/punycodetest.der View Binary file 0 comments Download
A net/data/ssl/certificates/punycodetest.pem View 1 chunk +73 lines, -0 lines 0 comments Download
M net/data/ssl/certificates/redundant-server-chain.pem View 1 chunk +269 lines, -212 lines 0 comments Download
M net/data/ssl/certificates/redundant-validated-chain.pem View 1 chunk +212 lines, -154 lines 0 comments Download
M net/data/ssl/certificates/redundant-validated-chain-root.pem View 1 chunk +72 lines, -14 lines 0 comments Download
M net/data/ssl/certificates/root_ca_cert.pem View 1 chunk +77 lines, -78 lines 0 comments Download
M net/data/ssl/certificates/spdy_pooling.pem View 1 chunk +57 lines, -37 lines 0 comments Download
M net/data/ssl/certificates/subjectAltName_sanity_check.pem View 1 chunk +58 lines, -36 lines 0 comments Download
M net/data/url_request_unittest/hpkp-headers.html.mock-http-headers View 1 chunk +1 line, -1 line 0 comments Download
M net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers View 1 chunk +1 line, -1 line 0 comments Download
M net/data/url_request_unittest/hsts-and-hpkp-headers2.html.mock-http-headers View 1 chunk +2 lines, -2 lines 0 comments Download
M net/http/disk_based_cert_cache_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
Ryan Sleevi
rsleevi@chromium.org changed reviewers: + mattm@chromium.org
6 years, 3 months ago (2014-08-28 04:13:45 UTC) #1
Ryan Sleevi
matt: Mind taking a look at the small test updates? The scripts to generate these ...
6 years, 3 months ago (2014-08-28 04:13:45 UTC) #2
mattm
https://codereview.chromium.org/515813002/diff/20001/net/cert/cert_verify_proc_unittest.cc File net/cert/cert_verify_proc_unittest.cc (left): https://codereview.chromium.org/515813002/diff/20001/net/cert/cert_verify_proc_unittest.cc#oldcode561 net/cert/cert_verify_proc_unittest.cc:561: GetTestCertsDirectory(), "name_constraint_ok.crt", CL doesn't delete name_constraint_ok.crt
6 years, 3 months ago (2014-08-28 21:26:25 UTC) #3
Ryan Sleevi
Nuked. PTAL.
6 years, 3 months ago (2014-08-28 21:35:44 UTC) #4
mattm
lgtm
6 years, 3 months ago (2014-08-28 21:39:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/515813002/60001
6 years, 2 months ago (2014-09-26 20:06:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/18018)
6 years, 2 months ago (2014-09-26 21:19:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/515813002/60001
6 years, 2 months ago (2014-09-26 22:16:35 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001) as ed82a7a389a0c7d0fa7357c18d6b67bd2fcb8355
6 years, 2 months ago (2014-09-26 22:49:17 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 22:49:57 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/80daaf71e46826d627cbf97fe28ce50ceb46a827
Cr-Commit-Position: refs/heads/master@{#297061}

Powered by Google App Engine
This is Rietveld 408576698