Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler (Closed)

Created:
6 years, 3 months ago by fgorski
Modified:
6 years, 3 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GCM] Extracting GCMConnectionObserver from GCMAppHandler Extracting GCMConnectionObserver from GCMAppHandler * Updating consuming code: GCMInvalidationBridge * Updating GCMAppHandler overrides * Updating tests for GCMDriverDesktop BUG=407841 R=jianli@chromium.org Committed: https://crrev.com/0d5c00d862d3ea1362b2de2a6e01d8f273bc604e Cr-Commit-Position: refs/heads/master@{#292396}

Patch Set 1 #

Patch Set 2 : Finishing the CL on a box that compiles much faster... #

Total comments: 6

Patch Set 3 : Addressing CR feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -69 lines) Patch
M components/gcm_driver.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/gcm_driver/default_gcm_app_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/gcm_driver/default_gcm_app_handler.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M components/gcm_driver/fake_gcm_app_handler.h View 3 chunks +0 lines, -4 lines 0 comments Download
M components/gcm_driver/fake_gcm_app_handler.cc View 2 chunks +1 line, -9 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/gcm_driver/fake_gcm_driver.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_app_handler.h View 1 chunk +0 lines, -10 lines 0 comments Download
M components/gcm_driver/gcm_app_handler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
A components/gcm_driver/gcm_connection_observer.h View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A components/gcm_driver/gcm_connection_observer.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_android.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.h View 3 chunks +9 lines, -0 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop.cc View 4 chunks +14 lines, -21 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 1 9 chunks +45 lines, -5 lines 0 comments Download
M components/invalidation/gcm_invalidation_bridge.h View 3 chunks +4 lines, -0 lines 0 comments Download
M components/invalidation/gcm_invalidation_bridge.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
fgorski
fgorski@chromium.org changed reviewers: + semenzato@chromium.org
6 years, 3 months ago (2014-08-27 23:19:29 UTC) #1
fgorski
Jian, please take a look. Luigi, this solves the problems with forcing a GCM connection ...
6 years, 3 months ago (2014-08-27 23:19:29 UTC) #2
jianli
lgtm https://codereview.chromium.org/515763002/diff/20001/components/gcm_driver/gcm_connection_observer.h File components/gcm_driver/gcm_connection_observer.h (right): https://codereview.chromium.org/515763002/diff/20001/components/gcm_driver/gcm_connection_observer.h#newcode16 components/gcm_driver/gcm_connection_observer.h:16: // Defines the interface to provide handling and ...
6 years, 3 months ago (2014-08-27 23:34:17 UTC) #3
fgorski
Feedback addressed. https://codereview.chromium.org/515763002/diff/20001/components/gcm_driver/gcm_connection_observer.h File components/gcm_driver/gcm_connection_observer.h (right): https://codereview.chromium.org/515763002/diff/20001/components/gcm_driver/gcm_connection_observer.h#newcode16 components/gcm_driver/gcm_connection_observer.h:16: // Defines the interface to provide handling ...
6 years, 3 months ago (2014-08-27 23:51:45 UTC) #4
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 3 months ago (2014-08-27 23:51:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/515763002/40001
6 years, 3 months ago (2014-08-27 23:53:08 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 01:04:44 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:08:08 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/7203)
6 years, 3 months ago (2014-08-28 01:08:09 UTC) #9
pavely
pavely@chromium.org changed reviewers: + pavely@chromium.org
6 years, 3 months ago (2014-08-28 01:22:32 UTC) #10
pavely
components/invalidation lgtm
6 years, 3 months ago (2014-08-28 01:22:32 UTC) #11
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 3 months ago (2014-08-28 01:23:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/515763002/40001
6 years, 3 months ago (2014-08-28 01:25:21 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 01:29:37 UTC) #14
commit-bot: I haz the power
Failed to commit the patch.
6 years, 3 months ago (2014-08-28 01:29:38 UTC) #15
fgorski
The CQ bit was checked by fgorski@chromium.org
6 years, 3 months ago (2014-08-28 16:19:57 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fgorski@chromium.org/515763002/40001
6 years, 3 months ago (2014-08-28 16:21:02 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c1df1d06c155be0fa662da9d62fa9de5319cea21
6 years, 3 months ago (2014-08-28 16:21:58 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:00:02 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/0d5c00d862d3ea1362b2de2a6e01d8f273bc604e
Cr-Commit-Position: refs/heads/master@{#292396}

Powered by Google App Engine
This is Rietveld 408576698