components/gcm_driver/fake_gcm_driver.h - Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/fake_gcm_driver.h

Issue 515763002: [GCM] Extracting GCMConnectionObserver from GCMAppHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing CR feedback Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/fake_gcm_driver.h

diff --git a/components/gcm_driver/fake_gcm_driver.h b/components/gcm_driver/fake_gcm_driver.h

index cfe625586d13b408a3ab282d42d2e1bc1dc8978b..a549e1f60f727f8567fb722eb1097be5937ee5cc 100644

--- a/components/gcm_driver/fake_gcm_driver.h

+++ b/components/gcm_driver/fake_gcm_driver.h

@@ -23,6 +23,9 @@ class FakeGCMDriver : public GCMDriver {

virtual void RemoveAppHandler(const std::string& app_id) OVERRIDE;

virtual void OnSignedIn() OVERRIDE;

virtual void Purge() OVERRIDE;

+ virtual void AddConnectionObserver(GCMConnectionObserver* observer) OVERRIDE;

+ virtual void RemoveConnectionObserver(

+ GCMConnectionObserver* observer) OVERRIDE;

virtual void Enable() OVERRIDE;

virtual void Disable() OVERRIDE;

virtual GCMClient* GetGCMClientForTesting() const OVERRIDE;

« no previous file with comments | « components/gcm_driver/fake_gcm_app_handler.cc ('k') | components/gcm_driver/fake_gcm_driver.cc » ('j') | no next file with comments »