Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Unified Diff: net/base/load_timing_info_test_util.cc

Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporate the review Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/load_timing_info.h ('K') | « net/base/load_timing_info.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/load_timing_info_test_util.cc
diff --git a/net/base/load_timing_info_test_util.cc b/net/base/load_timing_info_test_util.cc
index a34a5832400b76fe3f6af2cc8989d323895d5f72..6862e49973465579916c494b20be126b74cf401b 100644
--- a/net/base/load_timing_info_test_util.cc
+++ b/net/base/load_timing_info_test_util.cc
@@ -45,6 +45,20 @@ void ExpectConnectTimingHasTimes(
}
}
+void ExpectServiceWorkerTimingHasNoTimes(
+ const LoadTimingInfo::ServiceWorkerTiming& serviceworker_timing) {
+ EXPECT_TRUE(serviceworker_timing.fetch_start.is_null());
+ EXPECT_TRUE(serviceworker_timing.fetch_ready.is_null());
+ EXPECT_TRUE(serviceworker_timing.fetch_end.is_null());
+}
+
+void ExpectServiceWorkerTimingHasTimes(
+ const LoadTimingInfo::ServiceWorkerTiming& serviceworker_timing) {
+ EXPECT_FALSE(serviceworker_timing.fetch_start.is_null());
+ EXPECT_FALSE(serviceworker_timing.fetch_ready.is_null());
+ EXPECT_FALSE(serviceworker_timing.fetch_end.is_null());
+}
+
void ExpectLoadTimingHasOnlyConnectionTimes(
const LoadTimingInfo& load_timing_info) {
EXPECT_TRUE(load_timing_info.request_start_time.is_null());
« net/base/load_timing_info.h ('K') | « net/base/load_timing_info.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698