Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2)

net/base/load_timing_info.h

Index: net/base/load_timing_info.h
diff --git a/net/base/load_timing_info.h b/net/base/load_timing_info.h
index 00dbabf55dc2a77e09f5395ad9f487770392505a..31a17351d65f59bf18769b39e97ac334eed5a4ac 100644
--- a/net/base/load_timing_info.h
+++ b/net/base/load_timing_info.h
@@ -91,6 +91,17 @@ struct NET_EXPORT LoadTimingInfo {
     base::TimeTicks ssl_end;
   };
 
+  // Contains the timing of ServiceWorker.
+  // These are all set by ServiceWrokerURLRequestJob.
+  struct NET_EXPORT_PRIVATE ServiceWorkerTiming {

[mmenke, 2014/09/02 19:10:43]

It's a layering violation for net/ to know about ServiceWorkerURLRequestJobs, or
service workers in general.  Suggest adding the new times directly to
ResourceResponseInfo, and setting them in PopulateResourceResponse.

There are a couple ways to attach them to the request - if you keep track of
ServiceWorkerURLRequestJobs somewhere, could find the right one for a request
and grab them directly.  If not, could attach them to the URLRequest via the
SupportsUserData API.  Open to other ideas.

[shimazu, 2014/09/04 03:32:41]

Thanks for your comment, and I tried the implementation as you said.
ServiceWorker's timing info is contained by ServiceWorkerURLRequestJob directly
and passed to ResourceResponseInfo via GetExtraResponseInfo().
On 2014/09/02 19:10:43, mmenke wrote:

+    ServiceWorkerTiming();
+    ~ServiceWorkerTiming();
+
+    base::TimeTicks fetch_start;
+    base::TimeTicks fetch_ready;
+    base::TimeTicks fetch_end;
+  };
+
   LoadTimingInfo();
   ~LoadTimingInfo();
 
@@ -127,6 +138,7 @@ struct NET_EXPORT LoadTimingInfo {
   base::TimeTicks proxy_resolve_end;
 
   ConnectTiming connect_timing;
+  ServiceWorkerTiming serviceworker_timing;
 
   // The time that sending HTTP request started / ended.
   base::TimeTicks send_start;