content/child/web_url_loader_impl.cc - Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/web_url_loader_impl.cc

Issue 515753003: Add ServiceWorker timing information on the popup panel in DevTools's Network tab (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate the review Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_url_request_job.cc ('K') | « content/child/resource_dispatcher.cc ('k') | content/common/resource_messages.cc » ('j') | net/base/load_timing_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/web_url_loader_impl.cc

diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc

index ba560b65593dff68bbdce1f7e24b8028acd8cb12..97ca0fd6cc61013003e248b991f02dc8c6a5a92e 100644

--- a/content/child/web_url_loader_impl.cc

+++ b/content/child/web_url_loader_impl.cc

@@ -164,6 +164,12 @@ void PopulateURLLoadTiming(const net::LoadTimingInfo& load_timing,

(load_timing.connect_timing.ssl_start - kNullTicks).InSecondsF());

url_timing->setSSLEnd(

(load_timing.connect_timing.ssl_end - kNullTicks).InSecondsF());

+ url_timing->setServiceWorkerFetchStart(

+ (load_timing.serviceworker_timing.fetch_start - kNullTicks).InSecondsF());

+ url_timing->setServiceWorkerFetchReady(

+ (load_timing.serviceworker_timing.fetch_ready - kNullTicks).InSecondsF());

+ url_timing->setServiceWorkerFetchEnd(

+ (load_timing.serviceworker_timing.fetch_end - kNullTicks).InSecondsF());

url_timing->setSendStart(

(load_timing.send_start - kNullTicks).InSecondsF());

url_timing->setSendEnd(