Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
515603002:
[Telemetry] Clean up host platform hack in AndroidPlatformBackend. (Closed)
Description[Telemetry] Clean up host platform hack in AndroidPlatformBackend.
BUG=
Committed: https://crrev.com/bb09ea0d942bd8ac75447a6a379849f5a14e5133
Cr-Commit-Position: refs/heads/master@{#292308}
Patch Set 1 #
Total comments: 1
Patch Set 2 : rebase #Patch Set 3 : rebase #
Messages
Total messages: 28 (0 generated)
tonyg@chromium.org changed reviewers: + nednguyen@google.com
tonyg@chromium.org changed reviewers: + dtu@chromium.org
https://codereview.chromium.org/515603002/diff/1/tools/telemetry/telemetry/co... File tools/telemetry/telemetry/core/platform/android_platform_backend.py (right): https://codereview.chromium.org/515603002/diff/1/tools/telemetry/telemetry/co... tools/telemetry/telemetry/core/platform/android_platform_backend.py:194: def CanLaunchApplication(self, application): Why does this function always return True?
On 2014/08/27 21:47:25, nednguyen wrote: > https://codereview.chromium.org/515603002/diff/1/tools/telemetry/telemetry/co... > File tools/telemetry/telemetry/core/platform/android_platform_backend.py > (right): > > https://codereview.chromium.org/515603002/diff/1/tools/telemetry/telemetry/co... > tools/telemetry/telemetry/core/platform/android_platform_backend.py:194: def > CanLaunchApplication(self, application): > Why does this function always return True? That's a bug that I'm fixing in https://codereview.chromium.org/510943002/ -- but I wanted to land this cleanup first separately.
lgtm
The CQ bit was checked by tonyg@chromium.org
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/515603002/1
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by tonyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/515603002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was checked by tonyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/515603002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by tonyg@chromium.org
The CQ bit was checked by tonyg@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/515603002/40001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as c414d88181e79166dbd69023a87fa7d792dd1339
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bb09ea0d942bd8ac75447a6a379849f5a14e5133 Cr-Commit-Position: refs/heads/master@{#292308} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
