Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: tools/telemetry/telemetry/core/platform/android_platform_backend.py

Issue 515603002: [Telemetry] Clean up host platform hack in AndroidPlatformBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/android_platform_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/android_platform_backend.py b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
index 4c5ff87a817f669a4352a51eb2ee0c272e429896..b9d6c238ba84e8d9a34f18e1b8ad0057a999fc4a 100644
--- a/tools/telemetry/telemetry/core/platform/android_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/android_platform_backend.py
@@ -31,13 +31,6 @@ except Exception:
surface_stats_collector = None
-_HOST_APPLICATIONS = [
- 'avconv',
- 'ipfw',
- 'perfhost',
- ]
-
-
class AndroidPlatformBackend(
linux_based_platform_backend.LinuxBasedPlatformBackend):
def __init__(self, device, no_performance_mode):
@@ -189,10 +182,6 @@ class AndroidPlatformBackend(
def LaunchApplication(
self, application, parameters=None, elevate_privilege=False):
- if application in _HOST_APPLICATIONS:
- platform.GetHostPlatform().LaunchApplication(
- application, parameters, elevate_privilege=elevate_privilege)
- return
if elevate_privilege:
raise NotImplementedError("elevate_privilege isn't supported on android.")
if not parameters:
@@ -200,19 +189,12 @@ class AndroidPlatformBackend(
self._device.RunShellCommand('am start ' + parameters + ' ' + application)
def IsApplicationRunning(self, application):
- if application in _HOST_APPLICATIONS:
- return platform.GetHostPlatform().IsApplicationRunning(application)
return len(self._device.GetPids(application)) > 0
def CanLaunchApplication(self, application):
- if application in _HOST_APPLICATIONS:
- return platform.GetHostPlatform().CanLaunchApplication(application)
return True
def InstallApplication(self, application):
- if application in _HOST_APPLICATIONS:
- platform.GetHostPlatform().InstallApplication(application)
- return
raise NotImplementedError(
'Please teach Telemetry how to install ' + application)
« no previous file with comments | « tools/telemetry/telemetry/core/backends/browser_backend.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698