Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 515583004: Update test cert generation scripts to use SHA-256 by default (Closed)

Created:
6 years, 3 months ago by Ryan Sleevi
Modified:
6 years, 2 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@test_cert_scripts
Project:
chromium
Visibility:
Public.

Description

Update test cert generation scripts to use SHA-256 by default This cleans up the README file to clearly indicate which certificates are real world certificates, which are generated by hand / by other sources, and which are generated via script (and which script). Additionally, several test certificates that were previously generated by hand and several test CRLSets that were hardcoded are now generated automatically by the scripts. BUG=401365 Committed: https://crrev.com/04b34e02245194b01c08cd5cfb350378797e8681 Cr-Commit-Position: refs/heads/master@{#297047}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -144 lines) Patch
M net/data/ssl/certificates/README View 1 2 10 chunks +123 lines, -120 lines 0 comments Download
M net/data/ssl/scripts/aia-test.cnf View 3 chunks +3 lines, -3 lines 0 comments Download
M net/data/ssl/scripts/ca.cnf View 4 chunks +27 lines, -3 lines 0 comments Download
M net/data/ssl/scripts/client-certs.cnf View 2 chunks +2 lines, -2 lines 0 comments Download
M net/data/ssl/scripts/ee.cnf View 3 chunks +13 lines, -1 line 0 comments Download
M net/data/ssl/scripts/eku-test.cnf View 1 chunk +1 line, -1 line 0 comments Download
M net/data/ssl/scripts/generate-test-certs.sh View 1 2 2 chunks +86 lines, -9 lines 0 comments Download
M net/data/ssl/scripts/policy.cnf View 3 chunks +3 lines, -3 lines 0 comments Download
M net/data/ssl/scripts/redundant-ca.cnf View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Ryan Sleevi
rsleevi@chromium.org changed reviewers: + wtc@chromium.org
6 years, 3 months ago (2014-08-28 04:06:24 UTC) #1
Ryan Sleevi
wtc: You game for reviewing this? I can pass it off to David or Adam ...
6 years, 3 months ago (2014-08-28 04:06:24 UTC) #2
wtc
Patch set 1 LGTM. 1. The CL's description should also describe the other changes in ...
6 years, 3 months ago (2014-08-28 21:28:10 UTC) #3
Ryan Sleevi
On 2014/08/28 21:28:10, wtc wrote: > Patch set 1 LGTM. > > 1. The CL's ...
6 years, 3 months ago (2014-08-28 21:32:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/515583004/20001
6 years, 2 months ago (2014-09-26 20:06:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/72010) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/61386) win_gpu ...
6 years, 2 months ago (2014-09-26 20:10:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/515583004/40001
6 years, 2 months ago (2014-09-26 20:48:02 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 67e84d4fea44c3c00df287556909069d7886579f
6 years, 2 months ago (2014-09-26 22:03:13 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 22:03:51 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/04b34e02245194b01c08cd5cfb350378797e8681
Cr-Commit-Position: refs/heads/master@{#297047}

Powered by Google App Engine
This is Rietveld 408576698