Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 515533005: win dw: Fallback to aliased if ClearType 'succeeds' but returns empty (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

win dw: Fallback to aliased if ClearType 'succeeds' but returns empty This appears to happen for some CJK fonts where DW only returns valid data for bitmaps, not for cleartype data. This has an artifact (of course) which is that during the run where this failure case is encountered, cleartype will appear incongrously next to aliased, which looks poor. So, we'll need to fallback at a higher level. However, for M37, having something visible is more desirable than rendering blank space for characters. For reference, two screenshots. M37 Stable and then with this patch: http://imgur.com/9pf3rB9,EiTb6Li See https://code.google.com/p/chromium/issues/detail?id=396624#c10 for content of test html file. R=shrikant@chromium.org,bungeman@chromium.org,eae@chromium.org,cpu@chromium.org BUG=chromium:407945

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M src/ports/SkScalerContext_win_dw.cpp View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
6 years, 3 months ago (2014-08-27 20:10:45 UTC) #1
scottmg
scottmg@chromium.org changed reviewers: + shrikant@chromium.org - skrikant@chromium.org
6 years, 3 months ago (2014-08-27 20:12:51 UTC) #2
scottmg
Oops, can't speel Shrikant's name apparently. :/
6 years, 3 months ago (2014-08-27 20:13:24 UTC) #3
scottmg
On 2014/08/27 20:13:24, scottmg wrote: > Oops, can't speel Shrikant's name apparently. :/ Sorry, moved ...
6 years, 3 months ago (2014-08-27 20:48:20 UTC) #4
eae
6 years, 3 months ago (2014-08-27 21:13:19 UTC) #5
Message was sent while issue was closed.
General approach seems fine, not sure a goto statement is the right
implementation though but I'll leave that up to the Skia reviewers.

Powered by Google App Engine
This is Rietveld 408576698