Ignore persisent settings on SPDY4.

Ignore persisent settings on SPDY4.

SpdySession::SendInitialData() now only retrieves and sends server-persisted
SPDY settings for SPDY/3.1 and below.

BUG=408348
Committed: https://crrev.com/b178316f9087ef10d3e4f327a7d1bff0e34f0586
Cr-Commit-Position: refs/heads/master@{#292972}

[Bence, 2014-08-28 20:07:31]

bnc@chromium.org changed reviewers:
+ jgraettinger@chromium.org

[Bence, 2014-08-28 20:07:58]

https://codereview.chromium.org/515353002/diff/1/net/spdy/spdy_session.cc
File net/spdy/spdy_session.cc (right):

https://codereview.chromium.org/515353002/diff/1/net/spdy/spdy_session.cc#new...
net/spdy/spdy_session.cc:2738: if (protocol_ <= kProtoSPDY31) {
Do we want to use persisent settings if protocol_ == ProtoQUIC1SPDY3?

[Johnny, 2014-08-29 16:03:57]

Nope not needed, SpdySession isn't instantiated in QUIC sessions.

https://codereview.chromium.org/515353002/diff/20001/net/spdy/spdy_session_un...
File net/spdy/spdy_session_unittest.cc (right):

https://codereview.chromium.org/515353002/diff/20001/net/spdy/spdy_session_un...
net/spdy/spdy_session_unittest.cc:1539: return;
We still want to run most of this test for SPDY4, only disabling the
|server_settings_frame| expectation below.

[Bence, 2014-08-29 20:00:29]

I would love to not ever initialize server_settings and server_settings_frame if
GetParam() == kProtoSPDY4, but when scoped_ptr<SpdyFrame> server_settings_frame
goes out of scope at the end of the if block, it breaks the test.

https://codereview.chromium.org/515353002/diff/20001/net/spdy/spdy_session_un...
File net/spdy/spdy_session_unittest.cc (right):

https://codereview.chromium.org/515353002/diff/20001/net/spdy/spdy_session_un...
net/spdy/spdy_session_unittest.cc:1539: return;
On 2014/08/29 16:03:57, Johnny wrote:
> We still want to run most of this test for SPDY4, only disabling the
> |server_settings_frame| expectation below.

Done.

[Johnny, 2014-09-02 16:36:10]

lgtm

[Bence, 2014-09-02 18:17:11]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2014-09-02 18:20:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bnc@chromium.org/515353002/40001

[commit-bot: I haz the power, 2014-09-02 19:07:02]

Committed patchset #3 (id:40001) as 1f87d9a18c15cf6043046608d85ee59e2d38c90a

[commit-bot: I haz the power, 2014-09-10 03:19:53]

Patchset 3 (id:??) landed as
https://crrev.com/b178316f9087ef10d3e4f327a7d1bff0e34f0586
Cr-Commit-Position: refs/heads/master@{#292972}