net/spdy/spdy_session_unittest.cc - Issue 515353002: Ignore persisent settings on SPDY4.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_session_unittest.cc

Issue 515353002: Ignore persisent settings on SPDY4. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable a |server_settings_frame| expectation only in unittest. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_session_unittest.cc

diff --git a/net/spdy/spdy_session_unittest.cc b/net/spdy/spdy_session_unittest.cc

index 86e503cab7ff282a88134f7da5bd3eee6565cafc..9fe8c861bca1025fada358bc5e8549db4e9686d8 100644

--- a/net/spdy/spdy_session_unittest.cc

+++ b/net/spdy/spdy_session_unittest.cc

@@ -1576,7 +1576,9 @@ TEST_P(SpdySessionTest, SendInitialDataOnNewSession) {

initial_max_concurrent_streams);

scoped_ptr<SpdyFrame> server_settings_frame(

spdy_util_.ConstructSpdySettings(server_settings));

- writes.push_back(CreateMockWrite(*server_settings_frame));

+ if (GetParam() <= kProtoSPDY31) {

+ writes.push_back(CreateMockWrite(*server_settings_frame));

+ }

session_deps_.stream_initial_recv_window_size = kInitialRecvWindowSize;

« no previous file with comments | « net/spdy/spdy_session.cc ('k') | no next file » | no next file with comments »