Manual fixups in PPAPI for scoped_refptr operator T* removal.

Manual fixups in PPAPI for scoped_refptr operator T* removal.

BUG=110610
Committed: https://crrev.com/a88f5b607e25278ee2a370db1823a14e717ab208
Cr-Commit-Position: refs/heads/master@{#292586}

[dcheng, 2014-08-28 16:40:17]

dcheng@chromium.org changed reviewers:
+ raymes@chromium.org

[dcheng, 2014-08-28 16:40:17]

Manual fixups for cases the automated tool opted not to handle (plus one diff
from code that landed after the original pass).

https://codereview.chromium.org/515283002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/pepper/pepper_file_io_host.cc (right):

https://codereview.chromium.org/515283002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/pepper/pepper_file_io_host.cc:113:
file_(BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)
Do we need to ref this? Most other places seem to ref their task runner.

https://codereview.chromium.org/515283002/diff/1/content/renderer/pepper/ppb_...
File content/renderer/pepper/ppb_var_deprecated_impl.cc (right):

https://codereview.chromium.org/515283002/diff/1/content/renderer/pepper/ppb_...
content/renderer/pepper/ppb_var_deprecated_impl.cc:65:
scoped_refptr<V8ObjectVar> object_var_;
This was actually found by a second pass of the tool. I'm not sure if this is
actually needed--the tool's heuristic is if a temporary scoped_refptr is being
stored into a field, the field should also be a scoped_refptr. Please let me
know if this is the right thing to do here.

https://codereview.chromium.org/515283002/diff/1/content/renderer/pepper/ppb_...
content/renderer/pepper/ppb_var_deprecated_impl.cc:65:
scoped_refptr<V8ObjectVar> object_var_;
This was actually found by a second pass of the tool. I'm not sure if this is
actually needed--the tool's heuristic is if a temporary scoped_refptr is being
stored into a field, the field should also be a scoped_refptr. Please let me
know if this is the right thing to do here.

[raymes, 2014-08-29 01:12:45]

lgtm

https://codereview.chromium.org/515283002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/pepper/pepper_file_io_host.cc (right):

https://codereview.chromium.org/515283002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/pepper/pepper_file_io_host.cc:113:
file_(BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)
On 2014/08/28 16:40:16, dcheng (OOO) wrote:
> Do we need to ref this? Most other places seem to ref their task runner.

It looks like the base::FileProxy holds a ref, so I think it's ok :)
https://code.google.com/p/chromium/codesearch#chromium/src/base/files/file_pr...

https://codereview.chromium.org/515283002/diff/1/content/renderer/pepper/ppb_...
File content/renderer/pepper/ppb_var_deprecated_impl.cc (right):

https://codereview.chromium.org/515283002/diff/1/content/renderer/pepper/ppb_...
content/renderer/pepper/ppb_var_deprecated_impl.cc:65:
scoped_refptr<V8ObjectVar> object_var_;
The class is only stack allocated so this shouldn't be necessary (although it
shouldn't hurt either).

Note: I reverted the change which includes this line so you might get a conflict
here :(

[dcheng, 2014-08-29 06:38:02]

https://codereview.chromium.org/515283002/diff/1/content/browser/renderer_hos...
File content/browser/renderer_host/pepper/pepper_file_io_host.cc (right):

https://codereview.chromium.org/515283002/diff/1/content/browser/renderer_hos...
content/browser/renderer_host/pepper/pepper_file_io_host.cc:113:
file_(BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)
On 2014/08/29 01:12:45, raymes wrote:
> On 2014/08/28 16:40:16, dcheng (OOO) wrote:
> > Do we need to ref this? Most other places seem to ref their task runner.
> 
> It looks like the base::FileProxy holds a ref, so I think it's ok :)
>
https://code.google.com/p/chromium/codesearch#chromium/src/base/files/file_pr...

OK I've removed this comment then.

https://codereview.chromium.org/515283002/diff/1/content/renderer/pepper/ppb_...
File content/renderer/pepper/ppb_var_deprecated_impl.cc (right):

https://codereview.chromium.org/515283002/diff/1/content/renderer/pepper/ppb_...
content/renderer/pepper/ppb_var_deprecated_impl.cc:65:
scoped_refptr<V8ObjectVar> object_var_;
On 2014/08/29 01:12:45, raymes wrote:
> The class is only stack allocated so this shouldn't be necessary (although it
> shouldn't hurt either).
> 
> Note: I reverted the change which includes this line so you might get a
conflict
> here :(

I've rebased and removed this diff.

[dcheng, 2014-08-29 06:38:06]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-08-29 06:39:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/515283002/20001

[commit-bot: I haz the power, 2014-08-29 07:44:47]

Committed patchset #2 (id:20001) as 89bd75c14420a721fe96642eacb3b12d34518c26

[commit-bot: I haz the power, 2014-09-10 03:06:51]

Patchset 2 (id:??) landed as
https://crrev.com/a88f5b607e25278ee2a370db1823a14e717ab208
Cr-Commit-Position: refs/heads/master@{#292586}