Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 515063004: Better error message in cc PRESUBMIT (Closed)

Created:
6 years, 3 months ago by weiliangc
Modified:
6 years, 3 months ago
Reviewers:
Ian Vollick, danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Better error message in cc PRESUBMIT PRESUBMIT checks for usage of FIXME, so added that to error message. Committed: https://crrev.com/941dbec971267977fa9dbb92bf72af3b4b772ff2 Cr-Commit-Position: refs/heads/master@{#292431}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M cc/PRESUBMIT.py View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 14 (0 generated)
weiliangc
weiliangc@chromium.org changed reviewers: + vollick@chromium.org
6 years, 3 months ago (2014-08-28 17:36:12 UTC) #1
weiliangc
aha, forgot to publish. Here you go
6 years, 3 months ago (2014-08-28 17:36:27 UTC) #2
Ian Vollick
On 2014/08/28 17:36:27, weiliangc wrote: > aha, forgot to publish. Here you go lgtm.
6 years, 3 months ago (2014-08-28 17:37:21 UTC) #3
Ian Vollick
https://codereview.chromium.org/515063004/diff/1/cc/PRESUBMIT.py File cc/PRESUBMIT.py (right): https://codereview.chromium.org/515063004/diff/1/cc/PRESUBMIT.py#newcode145 cc/PRESUBMIT.py:145: 'Use TODO instead of FIX' + 'ME', This is ...
6 years, 3 months ago (2014-08-28 17:37:26 UTC) #4
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 3 months ago (2014-08-28 17:37:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/515063004/1
6 years, 3 months ago (2014-08-28 17:38:34 UTC) #6
danakj
danakj@chromium.org changed reviewers: + danakj@chromium.org
6 years, 3 months ago (2014-08-28 17:38:48 UTC) #7
danakj
Remove the BUG= from the description if you're not using it please
6 years, 3 months ago (2014-08-28 17:38:48 UTC) #8
danakj
The CQ bit was unchecked by danakj@chromium.org
6 years, 3 months ago (2014-08-28 17:38:52 UTC) #9
weiliangc
On 2014/08/28 17:38:48, danakj wrote: > Remove the BUG= from the description if you're not ...
6 years, 3 months ago (2014-08-28 17:39:44 UTC) #10
weiliangc
The CQ bit was checked by weiliangc@chromium.org
6 years, 3 months ago (2014-08-28 17:40:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/weiliangc@chromium.org/515063004/1
6 years, 3 months ago (2014-08-28 17:41:42 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0ee36dbf5590691c9057ff2eb53113ac7cd60c6e
6 years, 3 months ago (2014-08-28 18:56:26 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:01:09 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/941dbec971267977fa9dbb92bf72af3b4b772ff2
Cr-Commit-Position: refs/heads/master@{#292431}

Powered by Google App Engine
This is Rietveld 408576698