cc/PRESUBMIT.py - Issue 515063004: Better error message in cc PRESUBMIT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/PRESUBMIT.py

Issue 515063004: Better error message in cc PRESUBMIT (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/PRESUBMIT.py

diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py

index f9a0acb03f43096bf311b9d70c9904e3645837a3..6c08441f405eea1d402681b81e62660a17457b28 100644

--- a/cc/PRESUBMIT.py

+++ b/cc/PRESUBMIT.py

@@ -141,7 +141,8 @@ def CheckTodos(input_api, output_api):

if errors:

return [output_api.PresubmitError(

- 'All TODO comments should be of the form TODO(name).',

+ 'All TODO comments should be of the form TODO(name). ' +

+ 'Use TODO instead of FIX' + 'ME',

Ian Vollick 2014/08/28 17:37:26 This is amazing.

items=errors)]

return []

« no previous file with comments | « no previous file | no next file » | no next file with comments »