Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 515003004: Add pnacl-freeze to the tests_lit/lit.cfg. Also, unsigned vs signed. (Closed)

Created:
6 years, 3 months ago by jvoung (off chromium)
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Add pnacl-freeze to the tests_lit/lit.cfg. Also, unsigned vs signed. Otherwise, I don't have pnacl-freeze in my path, and I think the lit tests have trouble finding it. src/PNaClTranslator.cpp: In member function ‘uint32_t {anonymous}::FunctionParser::convertRelativeToAbsIndex(int32_t)’: src/PNaClTranslator.cpp:882:55: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] if (Id > 0 && AbsNextId < static_cast<uint32_t>(Id)) { ^ BUG=none R=kschimpf@google.com, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ce58163

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/PNaClTranslator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/lit.cfg View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jvoung (off chromium)
jvoung@chromium.org changed reviewers: + kschimpf@chromium.org, stichnot@chromium.org
6 years, 3 months ago (2014-08-28 02:30:14 UTC) #1
jvoung (off chromium)
6 years, 3 months ago (2014-08-28 02:30:55 UTC) #2
Karl
kschimpf@google.com changed reviewers: + kschimpf@google.com
6 years, 3 months ago (2014-08-28 03:49:18 UTC) #3
Karl
lgtm
6 years, 3 months ago (2014-08-28 03:49:18 UTC) #4
Jim Stichnoth
LGTM. Now that the build system has the Subzero directory next to llvm, I'm (for ...
6 years, 3 months ago (2014-08-28 16:52:52 UTC) #5
jvoung (off chromium)
6 years, 3 months ago (2014-08-28 17:04:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as ce58163 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698