src/PNaClTranslator.cpp - Issue 515003004: Add pnacl-freeze to the tests_lit/lit.cfg. Also, unsigned vs signed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/PNaClTranslator.cpp

Issue 515003004: Add pnacl-freeze to the tests_lit/lit.cfg. Also, unsigned vs signed. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/PNaClTranslator.cpp

diff --git a/src/PNaClTranslator.cpp b/src/PNaClTranslator.cpp

index 5381315b2c977a0970aff7ead2df6eaf8619b3d1..d7dc0c3ec8f1260b2e758f9f78824513b51a8381 100644

--- a/src/PNaClTranslator.cpp

+++ b/src/PNaClTranslator.cpp

@@ -879,7 +879,7 @@ private:

// an absolute value index.

uint32_t convertRelativeToAbsIndex(int32_t Id) {

int32_t AbsNextId = CachedNumGlobalValueIDs + LocalOperands.size();

- if (Id > 0 && AbsNextId < static_cast<uint32_t>(Id)) {

+ if (Id > 0 && AbsNextId < Id) {

std::string Buffer;

raw_string_ostream StrBuf(Buffer);

StrBuf << "Invalid relative value id: " << Id

« no previous file with comments | « no previous file | tests_lit/lit.cfg » ('j') | no next file with comments »