Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 514453003: Update ipfw (dummynet) to run on linux kernel 3.13 (Closed)

Created:
6 years, 3 months ago by fmeawad
Modified:
6 years, 3 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@enableandroid
Project:
chromium
Visibility:
Public.

Description

Update ipfw (dummynet) to run on linux kernel 3.13 BUG= Committed: https://crrev.com/b4351227c8fd0c439ec9c6a77fccf78d8d08b0b8 Cr-Commit-Position: refs/heads/master@{#292281}

Patch Set 1 #

Patch Set 2 : Add warning that current ipfw binaries are only supported from linux kernel 3.13 #

Total comments: 2

Patch Set 3 : Enhance error messages displayed in case of ipfw install failure #

Patch Set 4 : Remove extra new lines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M tools/telemetry/bin/linux/ipfw.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/bin/linux/ipfw_mod.ko.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 2 3 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
fmeawad
fmeawad@chromium.org changed reviewers: + dtu@chromium.org, tonyg@chromium.org
6 years, 3 months ago (2014-08-27 00:13:56 UTC) #1
fmeawad
6 years, 3 months ago (2014-08-27 00:13:56 UTC) #2
tonyg
What's the error message like on older kernels? I'd like to make sure that it ...
6 years, 3 months ago (2014-08-27 00:15:34 UTC) #3
fmeawad
Added a warning message where I believe it might fail. PTAL.
6 years, 3 months ago (2014-08-27 00:29:04 UTC) #4
tonyg
lgtm https://codereview.chromium.org/514453003/diff/20001/tools/telemetry/telemetry/core/platform/linux_platform_backend.py File tools/telemetry/telemetry/core/platform/linux_platform_backend.py (right): https://codereview.chromium.org/514453003/diff/20001/tools/telemetry/telemetry/core/platform/linux_platform_backend.py#newcode110 tools/telemetry/telemetry/core/platform/linux_platform_backend.py:110: 'ipfw provided binaries are not supported for linux ...
6 years, 3 months ago (2014-08-27 15:55:55 UTC) #5
fmeawad
https://codereview.chromium.org/514453003/diff/20001/tools/telemetry/telemetry/core/platform/linux_platform_backend.py File tools/telemetry/telemetry/core/platform/linux_platform_backend.py (right): https://codereview.chromium.org/514453003/diff/20001/tools/telemetry/telemetry/core/platform/linux_platform_backend.py#newcode110 tools/telemetry/telemetry/core/platform/linux_platform_backend.py:110: 'ipfw provided binaries are not supported for linux kernel ...
6 years, 3 months ago (2014-08-27 23:10:44 UTC) #6
fmeawad
The CQ bit was checked by fmeawad@chromium.org
6 years, 3 months ago (2014-08-27 23:10:47 UTC) #7
fmeawad
The CQ bit was unchecked by fmeawad@chromium.org
6 years, 3 months ago (2014-08-27 23:11:05 UTC) #8
fmeawad
The CQ bit was checked by fmeawad@chromium.org
6 years, 3 months ago (2014-08-27 23:12:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fmeawad@chromium.org/514453003/60001
6 years, 3 months ago (2014-08-27 23:13:36 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 8757f98ccef7c8eb4dc53ee9ab66efe9beca8f9f
6 years, 3 months ago (2014-08-28 00:31:02 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:56:05 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b4351227c8fd0c439ec9c6a77fccf78d8d08b0b8
Cr-Commit-Position: refs/heads/master@{#292281}

Powered by Google App Engine
This is Rietveld 408576698