Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: tools/telemetry/telemetry/core/platform/linux_platform_backend.py

Issue 514453003: Update ipfw (dummynet) to run on linux kernel 3.13 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enableandroid
Patch Set: Remove extra new lines Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/bin/linux/ipfw_mod.ko.sha1 ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/linux_platform_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/linux_platform_backend.py b/tools/telemetry/telemetry/core/platform/linux_platform_backend.py
index 89d9dd392c575bb0ea850e5a125fb327d9bec1b9..1a6092cbf6d9f171a6c85c3cbee55c91688deadb 100644
--- a/tools/telemetry/telemetry/core/platform/linux_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/linux_platform_backend.py
@@ -96,7 +96,8 @@ class LinuxPlatformBackend(
ipfw_mod, cloud_storage.INTERNAL_BUCKET)
except cloud_storage.CloudStorageError, e:
logging.error(str(e))
- logging.error('You may proceed by manually installing dummynet. See: '
+ logging.error('You may proceed by manually building and installing'
+ 'dummynet for your kernel. See: '
'http://info.iet.unipi.it/~luigi/dummynet/')
sys.exit(1)
@@ -106,7 +107,10 @@ class LinuxPlatformBackend(
os.chmod(ipfw_bin, 0755)
subprocess.check_call(['sudo', 'cp', ipfw_bin, '/usr/local/sbin'])
- assert self.CanLaunchApplication('ipfw'), 'Failed to install ipfw'
+ assert self.CanLaunchApplication('ipfw'), 'Failed to install ipfw. ' \
+ 'ipfw provided binaries are not supported for linux kernel < 3.13. ' \
+ 'You may proceed by manually building and installing dummynet for ' \
+ 'your kernel. See: http://info.iet.unipi.it/~luigi/dummynet/'
def _InstallBinary(self, bin_name, fallback_package=None):
bin_path = support_binaries.FindPath(bin_name, self.GetOSName())
« no previous file with comments | « tools/telemetry/bin/linux/ipfw_mod.ko.sha1 ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698