chrome/browser/extensions/api/permissions/permissions_apitest.cc - Issue 51433002: Enable permission warnings from ManifestHandlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_apitest.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/permissions/permissions_apitest.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_apitest.cc b/chrome/browser/extensions/api/permissions/permissions_apitest.cc

index 736112f59038ea90a3a22f2d0545246ef93a4710..e3e1552eb0378881063cc03f5c10eaa53787a254 100644

--- a/chrome/browser/extensions/api/permissions/permissions_apitest.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_apitest.cc

@@ -72,10 +72,12 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OptionalPermissionsGranted) {

// Mark all the tested APIs as granted to bypass the confirmation UI.

APIPermissionSet apis;

apis.insert(APIPermission::kBookmark);

+ ManifestPermissionSet manifest_permissions;

URLPatternSet explicit_hosts;

AddPattern(&explicit_hosts, "http://*.c.com/*");

scoped_refptr<PermissionSet> granted_permissions =

- new PermissionSet(apis, explicit_hosts, URLPatternSet());

+ new PermissionSet(apis, manifest_permissions,

+ explicit_hosts, URLPatternSet());

ExtensionPrefs* prefs =

browser()->profile()->GetExtensionService()->extension_prefs();