chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc - Issue 51433002: Enable permission warnings from ManifestHandlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

Issue 51433002: Enable permission warnings from ManifestHandlers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_api_helpers.cc ('k') | chrome/browser/extensions/api/permissions/permissions_apitest.cc » ('j') | chrome/common/extensions/api/sockets/sockets_handler.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

diff --git a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

index fe3e86039ee11ba35a5a68222362c554cffc0894..4ac1b8118741963108bd560f0a4d683e1258f40e 100644

--- a/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

+++ b/chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc

@@ -37,7 +37,7 @@ TEST(ExtensionPermissionsAPIHelpers, Pack) {

AddPattern(&hosts, "http://b.com/*");

scoped_refptr<PermissionSet> permission_set =

- new PermissionSet(apis, hosts, URLPatternSet());

+ new PermissionSet(apis, ManifestPermissionSet(), hosts, URLPatternSet());

// Pack the permission set to value and verify its contents.

scoped_ptr<Permissions> permissions(PackPermissionSet(permission_set.get()));