Make the warning level consistent across the project

Make the warning level for blink consistent by making sure that config.gyp is included for every target that builds native code.

I found the the missing targets by looking trough the generated .ninja files and looking for missing -Wall or -Werror cflags.

BUG=312287
TBR=cdumez

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161301

[lgombos, 2013-10-31 19:07:34]

I think many assumes that config.gyp is included for every gyp target in blink -
so this CL might resolve many current and future problems as well.

[Nico, 2013-10-31 19:14:18]

https://codereview.chromium.org/51413003/diff/1/Source/testing/testing.gyp
File Source/testing/testing.gyp (right):

https://codereview.chromium.org/51413003/diff/1/Source/testing/testing.gyp#ne...
Source/testing/testing.gyp:57: '../config.gyp:config',
This should depend on unittest_config instead, right?

[Nico, 2013-10-31 19:16:28]

https://codereview.chromium.org/51413003/diff/1/Source/testing/testing.gyp
File Source/testing/testing.gyp (right):

https://codereview.chromium.org/51413003/diff/1/Source/testing/testing.gyp#ne...
Source/testing/testing.gyp:245: '../config.gyp:config',
(and this too)

[lgombos, 2013-10-31 19:39:24]

Fixed the wtf target as well, I missed that in the first version.

https://codereview.chromium.org/51413003/diff/1/Source/testing/testing.gyp
File Source/testing/testing.gyp (right):

https://codereview.chromium.org/51413003/diff/1/Source/testing/testing.gyp#ne...
Source/testing/testing.gyp:57: '../config.gyp:config',
On 2013/10/31 19:14:18, Nico wrote:
> This should depend on unittest_config instead, right?

Yes. Fixed.

https://codereview.chromium.org/51413003/diff/1/Source/testing/testing.gyp#ne...
Source/testing/testing.gyp:245: '../config.gyp:config',
On 2013/10/31 19:16:29, Nico wrote:
> (and this too)

Fixed.

[Nico, 2013-10-31 19:51:36]

lgtm, thanks!

However, this patch breaks building wtf for me. The following patch makes it go
again, so you probably want to include that in this cl too (but the int/unsigned
code looks a bit hairy, that should probably be in a separate Cl that cevans
should review):

diff --git a/Source/wtf/DateMath.cpp b/Source/wtf/DateMath.cpp
index 95952a3..0a551d5 100644
--- a/Source/wtf/DateMath.cpp
+++ b/Source/wtf/DateMath.cpp
@@ -100,11 +100,7 @@ namespace WTF {
 
 /* Constants */
 
-static const double minutesPerDay = 24.0 * 60.0;
 static const double secondsPerDay = 24.0 * 60.0 * 60.0;
-static const double secondsPerYear = 24.0 * 60.0 * 60.0 * 365.0;
-
-static const double usecPerSec = 1000000.0;
 
 static const double maxUnixTime = 2145859200.0; // 12/31/2037
 // ECMAScript asks not to support for a date of which total
diff --git a/Source/wtf/PartitionAlloc.cpp b/Source/wtf/PartitionAlloc.cpp
index 6452552..adfaf1d 100644
--- a/Source/wtf/PartitionAlloc.cpp
+++ b/Source/wtf/PartitionAlloc.cpp
@@ -359,7 +359,7 @@ void* partitionAllocSlowPath(PartitionBucket* bucket)
         // slots.
         // This tags the page as full so that free'ing can tell, and move
         // the page back into the non-full page list when appropriate.
-        ASSERT(next->numAllocatedSlots == partitionBucketSlots(bucket));
+        ASSERT(next->numAllocatedSlots ==
static_cast<int>(partitionBucketSlots(bucket)));
         next->numAllocatedSlots = -next->numAllocatedSlots;
         partitionUnlinkPage(next);
         ++bucket->numFullPages;
@@ -372,7 +372,7 @@ void* partitionAllocSlowPath(PartitionBucket* bucket)
     // replace this single page with the new page we choose.
     ASSERT(page == page->next);
     ASSERT(page == page->prev);
-    ASSERT(page == &bucket->root->seedPage || page->numAllocatedSlots ==
partitionBucketSlots(bucket));
+    ASSERT(page == &bucket->root->seedPage || page->numAllocatedSlots ==
static_cast<int>(partitionBucketSlots(bucket)));
     if (LIKELY(page != &bucket->root->seedPage)) {
         page->numAllocatedSlots = -page->numAllocatedSlots;
         ++bucket->numFullPages;
@@ -441,7 +441,7 @@ void partitionFreeSlowPath(PartitionPageHeader* page)
         partitionLinkPageBefore(page, bucket->currPage);
         bucket->currPage = page;
         page->numAllocatedSlots = -page->numAllocatedSlots - 2;
-        ASSERT(page->numAllocatedSlots == partitionBucketSlots(bucket) - 1);
+        ASSERT(page->numAllocatedSlots ==
static_cast<int>(partitionBucketSlots(bucket) - 1));
         --bucket->numFullPages;
     }
 }
diff --git a/Source/wtf/dtoa.cpp b/Source/wtf/dtoa.cpp
index 41d1ae5..9d24d96 100644
--- a/Source/wtf/dtoa.cpp
+++ b/Source/wtf/dtoa.cpp
@@ -603,14 +603,7 @@ static const double tens[] = {
 };
 
 static const double bigtens[] = { 1e16, 1e32, 1e64, 1e128, 1e256 };
-static const double tinytens[] = { 1e-16, 1e-32, 1e-64, 1e-128,
-    9007199254740992. * 9007199254740992.e-256
-    /* = 2^106 * 1e-256 */
-};
 
-/* The factor of 2^53 in tinytens[4] helps us avoid setting the underflow */
-/* flag unnecessarily.  It leads to a song and dance at the end of strtod. */
-#define Scale_Bit 0x10
 #define n_bigtens 5
 
 static ALWAYS_INLINE int quorem(BigInt& b, BigInt& S)

[lgombos, 2013-10-31 20:55:18]

> the int/unsigned
> code looks a bit hairy, that should probably be in a separate Cl that cevans
> should review):

Thanks. https://codereview.chromium.org/48663004/ .

[lgombos, 2013-11-04 21:32:53]

On 2013/10/31 20:55:18, lgombos wrote:

Waiting for clang fix from https://codereview.chromium.org/57433008 ...

[Nico, 2013-11-05 02:35:49]

With your WTF fix and ch.dumez' fix from today, I was able to build both Debug
and Release on linux with clang with this CL patched in, without compile errors.
I think this is ready to land now.

[commit-bot: I haz the power, 2013-11-05 02:41:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/51413003/80001

[commit-bot: I haz the power, 2013-11-05 04:34:57]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-11-05 04:40:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/51413003/80001

[commit-bot: I haz the power, 2013-11-05 04:40:43]

Change committed as 161301

[Inactive, 2013-11-05 14:24:44]

LGTM for bindings/