Issue 57433008: Declare kCachedPowersLength only if !ASSERT_DISABLED

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 57433008: Declare kCachedPowersLength only if !ASSERT_DISABLED (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
Nico, (unused - use chromium), eseidel

CC:
blink-reviews, yurys+blink_chromium.org, loislo+blink_chromium.org, adamk+blink_chromium.org, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Declare kCachedPowersLength only if !ASSERT_DISABLED The kCachedPowersLength global static variable is only used in assertions so we should only declare it if !ASSERT_DISABLED to avoid warnings at compile time. R=eseidel, thakis BUG=312287 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161295

Patch Set 1 #

Patch Set 2 : Use ASSERT_DISABLED define #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	Source/wtf/dtoa/cached-powers.cc	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/57433008/40001

7 years, 1 month ago (2013-11-04 21:25:46 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=1848

7 years, 1 month ago (2013-11-05 00:38:04 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/57433008/40001

7 years, 1 month ago (2013-11-05 00:38:26 UTC) #6

Message was sent while issue was closed.

Change committed as 161295

Expand Messages | Collapse Messages