Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 514033002: Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a (Closed)

Created:
6 years, 3 months ago by ramant (doing other things)
Modified:
6 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@unit_test_for_empty_packet_74041239
Project:
chromium
Visibility:
Public.

Description

Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a deque. Estimated to save ~3% of CPU based on pprof profiling of 100 large gets on tools/quic/end_to_end_test.cc. Merge internal change: 74054196 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -235 lines) Patch
M net/quic/congestion_control/tcp_loss_algorithm.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M net/quic/congestion_control/time_loss_algorithm.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/quic_sent_entropy_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_packet_manager.h View 2 chunks +3 lines, -6 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 13 chunks +41 lines, -59 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_unacked_packet_map.h View 6 chunks +13 lines, -6 lines 0 comments Download
M net/quic/quic_unacked_packet_map.cc View 9 chunks +117 lines, -136 lines 0 comments Download
M net/quic/quic_unacked_packet_map_test.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 3 months ago (2014-08-28 00:31:07 UTC) #1
Ryan Hamilton
6 years, 3 months ago (2014-08-28 00:50:14 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698