net/quic/quic_sent_entropy_manager.cc - Issue 514033002: Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_entropy_manager.cc

Issue 514033002: Optimize QuicUnackedPacketMap by changing from a LinkedHashMap to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@unit_test_for_empty_packet_74041239

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_entropy_manager.cc

diff --git a/net/quic/quic_sent_entropy_manager.cc b/net/quic/quic_sent_entropy_manager.cc

index ff19a02c669b457d5a95aef0be82e32ddcc05dc8..206a9ffe566a6582a4244196b15878cd240b5fc1 100644

--- a/net/quic/quic_sent_entropy_manager.cc

+++ b/net/quic/quic_sent_entropy_manager.cc

@@ -48,7 +48,7 @@ void QuicSentEntropyManager::RecordPacketEntropyHash(

// Ensure packets always are recorded in order.

// Every packet's entropy is recorded, even if it's not sent, so there

// are not sequence number gaps.

- DCHECK_LT(GetLargestPacketWithEntropy(), sequence_number);

+ DCHECK_EQ(GetLargestPacketWithEntropy() + 1, sequence_number);

}

packets_entropy_.push_back(entropy_hash);

DVLOG(2) << "Recorded sequence number " << sequence_number

« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_sent_packet_manager.h » ('j') | no next file with comments »