Fix enable a11y tests for History and fix failures

Fix enable a11y tests for History and fix failures

Enable accessibility tests for history page.
Add aria-label for the history search box.
Add aria-label to Today/Previous/Next.
Add aria-label to all the checkboxes.
Add aria-hidden when list is not visible.

BUG=406150
Committed: https://crrev.com/4b75c19c85db40c25a93c5d7d88e3d786717a798
Cr-Commit-Position: refs/heads/master@{#295560}

[hcarmona, 2014-08-27 22:20:06]

hcarmona@chromium.org changed reviewers:
+ aboxhall@chromium.org, dbeam@chromium.org

[hcarmona, 2014-08-27 23:13:04]

Hi Alice and Dan,

I've added you both as code reviewers since Alice's name came up when talking
about accessibility and Dan's the owner of the files that I'm touching.

-Hector

[Dan Beam, 2014-08-28 00:14:12]

lgtm given new patchset that removes [alt] (please make sure aboxhall@ or
somebody with more a11y experience OKs this, though)

https://codereview.chromium.org/513923003/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.html (right):

https://codereview.chromium.org/513923003/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.html:81:
i18n-values="aria-label:searchButton"
nit:

  i18n-values="aria-label:searchButton" required>

if it fits

https://codereview.chromium.org/513923003/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.html:90: disabled>
this could probably fit in 2 lines, e.g.

  <button id="range-today" i18n-content="rangeToday"
      i18n-values="aria-label:rangeToday" disabled></button>

(maybe with the </button> on the next line if you prefer this)

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
File chrome/test/data/webui/history_browsertest.js (right):

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
chrome/test/data/webui/history_browsertest.js:144: typedefCppFixture:
'HistoryUIBrowserTest',
nit: \n

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
chrome/test/data/webui/history_browsertest.js:144: typedefCppFixture:
'HistoryUIBrowserTest',
/** @override */

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
chrome/test/data/webui/history_browsertest.js:145: runAccessibilityChecks: true,
nit: \n

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
chrome/test/data/webui/history_browsertest.js:145: runAccessibilityChecks: true,
/** @override */

[aboxhall, 2014-08-28 15:21:42]

https://codereview.chromium.org/513923003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/513923003/diff/20001/chrome/browser/resources...
chrome/browser/resources/history/history.js:1330: resultsList.style.height = 0;
Any reason not to just set this to display: none? Would it cause weirdness when
re-showing it? (display: none will hide it from a11y as well, so you wouldn't
need aria-hidden.)

[hcarmona, 2014-09-03 20:49:34]

https://codereview.chromium.org/513923003/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.html (right):

https://codereview.chromium.org/513923003/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.html:81:
i18n-values="aria-label:searchButton"
On 2014/08/28 00:14:12, Dan Beam wrote:
> nit:
> 
>   i18n-values="aria-label:searchButton" required>
> 
> if it fits

Done.

https://codereview.chromium.org/513923003/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.html:90: disabled>
On 2014/08/28 00:14:12, Dan Beam wrote:
> this could probably fit in 2 lines, e.g.
> 
>   <button id="range-today" i18n-content="rangeToday"
>       i18n-values="aria-label:rangeToday" disabled></button>
> 
> (maybe with the </button> on the next line if you prefer this)

Done.

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
File chrome/test/data/webui/history_browsertest.js (right):

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
chrome/test/data/webui/history_browsertest.js:144: typedefCppFixture:
'HistoryUIBrowserTest',
On 2014/08/28 00:14:12, Dan Beam wrote:
> /** @override */

Done.

https://codereview.chromium.org/513923003/diff/1/chrome/test/data/webui/histo...
chrome/test/data/webui/history_browsertest.js:145: runAccessibilityChecks: true,
On 2014/08/28 00:14:12, Dan Beam wrote:
> /** @override */

Done.

https://codereview.chromium.org/513923003/diff/20001/chrome/browser/resources...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/513923003/diff/20001/chrome/browser/resources...
chrome/browser/resources/history/history.js:1330: resultsList.style.height = 0;
When I changed this to display: none, the collapse animations disappeared. It
may need to stay as aria-hidden to avoid breaking the collapse effect on the
list.


On 2014/08/28 15:21:41, aboxhall_ooo_until_oct_6 wrote:
> Any reason not to just set this to display: none? Would it cause weirdness
when
> re-showing it? (display: none will hide it from a11y as well, so you wouldn't
> need aria-hidden.)

[hcarmona, 2014-09-09 22:12:42]

hcarmona@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[hcarmona, 2014-09-09 22:14:17]

Added dmazzoni@ as a reviewer.

[dmazzoni, 2014-09-09 22:32:55]

lgtm

Looks great! I'm happy that the issues it caught seem like they were helpful and
not false positives.

[Dan Beam, 2014-09-09 22:41:18]

lgtm

[hcarmona, 2014-09-18 20:02:37]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2014-09-18 20:04:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/513923003/40001

[commit-bot: I haz the power, 2014-09-18 21:43:50]

Committed patchset #3 (id:40001) as f655b9bbc6c0cd12f0b836b6f300f806a6c6ebb8

[commit-bot: I haz the power, 2014-09-18 21:44:37]

Patchset 3 (id:??) landed as
https://crrev.com/4b75c19c85db40c25a93c5d7d88e3d786717a798
Cr-Commit-Position: refs/heads/master@{#295560}