Chromium Code Reviews Chromium Code Reviews
Issue 513923003:
Fix enable a11y tests for History and fix failures (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE HTML> | 1 <!DOCTYPE HTML> |
| 2 <html i18n-values="dir:textdirection;"> | 2 <html i18n-values="dir:textdirection;"> |
| 3 <head> | 3 <head> |
| 4 <meta charset="utf-8"> | 4 <meta charset="utf-8"> |
| 5 <if expr="is_android or is_ios"> | 5 <if expr="is_android or is_ios"> |
| 6 <meta name="viewport" content="width=device-width, initial-scale=1.0, | 6 <meta name="viewport" content="width=device-width, initial-scale=1.0, |
| 7 maximum-scale=1.0, user-scalable=no"> | 7 maximum-scale=1.0, user-scalable=no"> |
| 8 </if> | 8 </if> |
| 9 <title i18n-content="title"></title> | 9 <title i18n-content="title"></title> |
| 10 <link rel="stylesheet" href="chrome://resources/css/butter_bar.css"> | 10 <link rel="stylesheet" href="chrome://resources/css/butter_bar.css"> |
| (...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 70 <div id="overlay" class="overlay" hidden> | 70 <div id="overlay" class="overlay" hidden> |
| 71 <include src="alert_overlay.html"> | 71 <include src="alert_overlay.html"> |
| 72 </div> | 72 </div> |
| 73 </if> | 73 </if> |
| 74 | 74 |
| 75 <div id="history-page" class="page"> | 75 <div id="history-page" class="page"> |
| 76 <div id="scrolling-container"> | 76 <div id="scrolling-container"> |
| 77 <header> | 77 <header> |
| 78 <h1 i18n-content="history"></h1> | 78 <h1 i18n-content="history"></h1> |
| 79 <div id="search-form" class="search-field-container"> | 79 <div id="search-form" class="search-field-container"> |
| 80 <input type="search" id="search-field" required> | 80 <input type="search" id="search-field" |
| 81 <input type="submit" id="search-button" i18n-values="value:searchButton" > | 81 i18n-values="aria-label:searchButton" |
|
Dan Beam
2014/08/28 00:14:12
nit:
i18n-values="aria-label:searchButton" requ
hcarmona
2014/09/03 20:49:34
Done.
| |
| 82 required> | |
| 83 <input type="submit" id="search-button" | |
| 84 i18n-values="value:searchButton"> | |
| 82 </div> | 85 </div> |
| 83 <div id="filter-controls" hidden> | 86 <div id="filter-controls" hidden> |
| 84 <button id="range-today" i18n-content="rangeToday" disabled></button> | 87 <button id="range-today" |
| 85 <button id="range-previous" i18n-values="alt:rangePrevious" disabled> | 88 i18n-content="rangeToday" |
| 89 i18n-values="aria-label:rangeToday" | |
| 90 disabled> | |
|
Dan Beam
2014/08/28 00:14:12
this could probably fit in 2 lines, e.g.
<butto
hcarmona
2014/09/03 20:49:34
Done.
| |
| 86 </button> | 91 </button> |
| 87 <button id="range-next" i18n-values="alt:rangeNext" disabled> | 92 <button id="range-previous" |
| 93 i18n-values="alt:rangePrevious; aria-label:rangePrevious" | |
| 94 disabled> | |
| 95 </button> | |
| 96 <button id="range-next" | |
| 97 i18n-values="alt:rangeNext; aria-label:rangeNext" | |
| 98 disabled> | |
| 88 </button> | 99 </button> |
| 89 <div id="display-filter-controls"> | 100 <div id="display-filter-controls"> |
| 90 <div class="display-filter-button"> | 101 <div class="display-filter-button"> |
| 91 <label for="timeframe-filter-all"> | 102 <label for="timeframe-filter-all"> |
| 92 <input id="timeframe-filter-all" type="radio" | 103 <input id="timeframe-filter-all" type="radio" |
| 93 name="timeframe-filter" value="0" checked> | 104 name="timeframe-filter" value="0" checked> |
| 94 <span i18n-content="rangeAllTime" class="first-button-component"> | 105 <span i18n-content="rangeAllTime" class="first-button-component"> |
| 95 </span> | 106 </span> |
| 96 </label> | 107 </label> |
| 97 </div> | 108 </div> |
| (...skipping 13 matching lines...) Expand all Loading... | |
| 111 </label> | 122 </label> |
| 112 </div> | 123 </div> |
| 113 </div> | 124 </div> |
| 114 </div> | 125 </div> |
| 115 </header> | 126 </header> |
| 116 <if expr="not is_android"> | 127 <if expr="not is_android"> |
| 117 <div id="other-devices" class="other-devices"></div> | 128 <div id="other-devices" class="other-devices"></div> |
| 118 </if> | 129 </if> |
| 119 <div id="top-container"> | 130 <div id="top-container"> |
| 120 <div id="editing-controls"> | 131 <div id="editing-controls"> |
| 121 <button id="clear-browsing-data" i18n-content="clearAllHistory"></button > | 132 <button id="clear-browsing-data" i18n-content="clearAllHistory"> |
| 133 </button> | |
| 122 <button id="remove-selected" disabled="disabled" | 134 <button id="remove-selected" disabled="disabled" |
| 123 i18n-content="removeSelected"></button> | 135 i18n-content="removeSelected"></button> |
| 124 </div> | 136 </div> |
| 125 <div id="notification-bar" hidden></div> | 137 <div id="notification-bar" hidden></div> |
| 126 </div> | 138 </div> |
| 127 | 139 |
| 128 <div id="results-display"></div> | 140 <div id="results-display"></div> |
| 129 <div id="loading-spinner" hidden> | 141 <div id="loading-spinner" hidden> |
| 130 <span id="loading"> | 142 <span id="loading"> |
| 131 <div id="spinner" class="inline-spinner"></div> | 143 <div id="spinner" class="inline-spinner"></div> |
| (...skipping 14 matching lines...) Expand all Loading... | |
| 146 | 158 |
| 147 <menu id="action-menu" hidden> | 159 <menu id="action-menu" hidden> |
| 148 <button id="more-from-site" i18n-content="moreFromSite"></button> | 160 <button id="more-from-site" i18n-content="moreFromSite"></button> |
| 149 <button id="remove-visit" i18n-content="removeFromHistory"></button> | 161 <button id="remove-visit" i18n-content="removeFromHistory"></button> |
| 150 </menu> | 162 </menu> |
| 151 | 163 |
| 152 <script src="chrome://history-frame/strings.js"></script> | 164 <script src="chrome://history-frame/strings.js"></script> |
| 153 <script src="chrome://resources/js/i18n_template2.js"></script> | 165 <script src="chrome://resources/js/i18n_template2.js"></script> |
| 154 </body> | 166 </body> |
| 155 </html> | 167 </html> |
| OLD | NEW |
