Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 513793003: Revert of Try backing SkPicture with SkRecord in Chromium. (Closed)

Created:
6 years, 3 months ago by mtklein
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Stephen White, robertphillips, Tom Hudson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Try backing SkPicture with SkRecord in Chromium. (patchset #2 of https://codereview.chromium.org/504823003/) Reason for revert: Appears to leak bitmaps. Original issue's description: > Try backing SkPicture with SkRecord in Chromium. > > This is our first attempt, mostly to feel this out. Performance and > correctness problems are both possible. Please revert this if a benchmark even > smells funny. > > That said, we've been working on this a while, are pretty confident it's good > stuff, and have had Skia's internal testing entirely switched over for a week. > Parts of Chromium that serialize and deserialize SkPictures are already > switched over. This CL finishes things off by switching the default > recorded-from-scratch SkPicture to use SkRecord too. > > BUG= > > Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c TBR=reed@google.com,senorblanco@chromium.org,eroman@chromium.org,mtklein@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a1a039aef4435565568544a2d4684a6f53d56b99 Cr-Commit-Position: refs/heads/master@{#292189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -7 lines) Patch
M skia/config/SkUserConfig.h View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mtklein
Created Revert of Try backing SkPicture with SkRecord in Chromium.
6 years, 3 months ago (2014-08-27 18:23:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@google.com/513793003/1
6 years, 3 months ago (2014-08-27 18:25:17 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-27 18:25:18 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-08-27 18:25:19 UTC) #4
bungeman-chromium
On 2014/08/27 18:25:19, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 3 months ago (2014-08-27 18:28:19 UTC) #5
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 3 months ago (2014-08-27 18:28:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtklein@google.com/513793003/1
6 years, 3 months ago (2014-08-27 18:29:18 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7f5bb946c87b40af7a63d7acc779136d37c6ff0b
6 years, 3 months ago (2014-08-27 18:30:12 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:52:54 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1a039aef4435565568544a2d4684a6f53d56b99
Cr-Commit-Position: refs/heads/master@{#292189}

Powered by Google App Engine
This is Rietveld 408576698