Source/core/html/HTMLInputElement.cpp - Issue 513783002: Dispatch change event for input type=color when colorpicker is closed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 513783002: Dispatch change event for input type=color when colorpicker is closed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index 5d9b56ce74408ae5f8becae7c8b3cc747c925f01..9d33596048351da1130749f05788b9dab1409a0e 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -1492,6 +1492,7 @@ void HTMLInputElement::selectColorInColorChooser(const Color& color)

if (!m_inputType->isColorControl())

return;

static_cast<ColorInputType*>(m_inputType.get())->didChooseColor(color);

+ static_cast<ColorInputType*>(m_inputType.get())->didEndChooser();

keishi 2014/09/09 11:55:51 You could add a separate method like Internals::en

Habib Virji 2014/09/10 16:30:54 Done.

}

HTMLElement* HTMLInputElement::list() const

« no previous file with comments | « no previous file | Source/core/html/forms/ColorInputType.cpp » ('j') | Source/core/html/forms/ColorInputType.cpp » ('J')