Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Side by Side Diff: Source/core/html/HTMLInputElement.cpp

Issue 513783002: Dispatch change event for input type=color when colorpicker is closed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org) 7 * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 10 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
(...skipping 1474 matching lines...) Expand 10 before | Expand all | Expand 10 after
1485 if (RadioButtonGroupScope* scope = radioButtonGroupScope()) 1485 if (RadioButtonGroupScope* scope = radioButtonGroupScope())
1486 scope->requiredAttributeChanged(this); 1486 scope->requiredAttributeChanged(this);
1487 m_inputTypeView->requiredAttributeChanged(); 1487 m_inputTypeView->requiredAttributeChanged();
1488 } 1488 }
1489 1489
1490 void HTMLInputElement::selectColorInColorChooser(const Color& color) 1490 void HTMLInputElement::selectColorInColorChooser(const Color& color)
1491 { 1491 {
1492 if (!m_inputType->isColorControl()) 1492 if (!m_inputType->isColorControl())
1493 return; 1493 return;
1494 static_cast<ColorInputType*>(m_inputType.get())->didChooseColor(color); 1494 static_cast<ColorInputType*>(m_inputType.get())->didChooseColor(color);
1495 static_cast<ColorInputType*>(m_inputType.get())->didEndChooser();
keishi 2014/09/09 11:55:51 You could add a separate method like Internals::en
Habib Virji 2014/09/10 16:30:54 Done.
1495 } 1496 }
1496 1497
1497 HTMLElement* HTMLInputElement::list() const 1498 HTMLElement* HTMLInputElement::list() const
1498 { 1499 {
1499 return dataList(); 1500 return dataList();
1500 } 1501 }
1501 1502
1502 HTMLDataListElement* HTMLInputElement::dataList() const 1503 HTMLDataListElement* HTMLInputElement::dataList() const
1503 { 1504 {
1504 if (!m_hasNonEmptyList) 1505 if (!m_hasNonEmptyList)
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
1887 { 1888 {
1888 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ; 1889 return m_inputType->shouldDispatchFormControlChangeEvent(oldValue, newValue) ;
1889 } 1890 }
1890 1891
1891 void HTMLInputElement::didNotifySubtreeInsertionsToDocument() 1892 void HTMLInputElement::didNotifySubtreeInsertionsToDocument()
1892 { 1893 {
1893 listAttributeTargetChanged(); 1894 listAttributeTargetChanged();
1894 } 1895 }
1895 1896
1896 } // namespace 1897 } // namespace
OLDNEW
« no previous file with comments | « no previous file | Source/core/html/forms/ColorInputType.cpp » ('j') | Source/core/html/forms/ColorInputType.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698