Autofill: Prefer maxLength to size attribute for form filling heuristics.

Autofill: Prefer maxLength to size attribute for form filling heuristics.

BUG=63440
TEST=browser_tests --gtest_filter=FormManagerTest.*

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=66850

[dhollowa, 2010-11-18 18:26:46]

http://codereview.chromium.org/5137004/diff/1/chrome/renderer/form_manager.cc
File chrome/renderer/form_manager.cc (right):

http://codereview.chromium.org/5137004/diff/1/chrome/renderer/form_manager.cc...
chrome/renderer/form_manager.cc:313: // TODO(isherman): Add "524288" as a named
constant to the WebKit API
It looks to me like the use of |size| was misguided originally.  In the original
bug 38218, the problematic site
https://scgi.ebay.com/ws/eBayISAPI.dll?RegisterEnterInfo has a correct
|maxlength| attribute.

Let's go ahead and remove the |size| attribute from webkit_glue::FormField and
replace it with |maxlength|.

I also notice that when submitting the form the saved profile has an incorrect
number.

[Ilya Sherman, 2010-11-19 02:33:44]

http://codereview.chromium.org/5137004/diff/1/chrome/renderer/form_manager.cc
File chrome/renderer/form_manager.cc (right):

http://codereview.chromium.org/5137004/diff/1/chrome/renderer/form_manager.cc...
chrome/renderer/form_manager.cc:313: // TODO(isherman): Add "524288" as a named
constant to the WebKit API
On 2010/11/18 18:26:51, dhollowa wrote:
> It looks to me like the use of |size| was misguided originally.  In the
original
> bug 38218, the problematic site
> https://scgi.ebay.com/ws/eBayISAPI.dll?RegisterEnterInfo has a correct
> |maxlength| attribute.
> 
> Let's go ahead and remove the |size| attribute from webkit_glue::FormField and
> replace it with |maxlength|.

Done.

> I also notice that when submitting the form the saved profile has an incorrect
> number.

I figured out why this is happening; will address this in a separate cl

[dhollowa, 2010-11-19 02:54:04]

Looks like unit tests need some help.

[dhollowa, 2010-11-19 02:54:34]

On 2010/11/19 02:54:04, dhollowa wrote:
> Looks like unit tests need some help.

(Try bots fail to compile).

[dhollowa, 2010-11-19 03:00:28]

http://codereview.chromium.org/5137004/diff/4001/chrome/renderer/form_manager...
File chrome/renderer/form_manager_browsertest.cc (right):

http://codereview.chromium.org/5137004/diff/4001/chrome/renderer/form_manager...
chrome/renderer/form_manager_browsertest.cc:41: const int defaultMaxLength =
524288;
nit: kDefaultMaxLength.  Also, 524288 == 0x80000 if you like round numbers.

[Ilya Sherman, 2010-11-19 09:10:56]

On 2010/11/19 02:54:34, dhollowa wrote:
> On 2010/11/19 02:54:04, dhollowa wrote:
> > Looks like unit tests need some help.
> 
> (Try bots fail to compile).

Fixed.

On 2010/11/19 03:00:28, dhollowa wrote:
>
http://codereview.chromium.org/5137004/diff/4001/chrome/renderer/form_manager...
> File chrome/renderer/form_manager_browsertest.cc (right):
> 
>
http://codereview.chromium.org/5137004/diff/4001/chrome/renderer/form_manager...
> chrome/renderer/form_manager_browsertest.cc:41: const int defaultMaxLength =
> 524288;
> nit: kDefaultMaxLength.  Also, 524288 == 0x80000 if you like round numbers.

Done.

[dhollowa, 2010-11-19 15:45:22]

LGTM.

http://codereview.chromium.org/5137004/diff/15001/chrome/renderer/render_view...
File chrome/renderer/render_view_browsertest.cc (right):

http://codereview.chromium.org/5137004/diff/15001/chrome/renderer/render_view...
chrome/renderer/render_view_browsertest.cc:46: }
nit: }  // namespace