Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 513623002: Cleanup: Combine some identical conditionals in chrome gyp targets. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Combine some identical conditionals in chrome gyp targets. Committed: https://crrev.com/a7d8801090fc2c2da5a84b9c600666395d4a5d54 Cr-Commit-Position: refs/heads/master@{#292125}

Patch Set 1 #

Patch Set 2 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -35 lines) Patch
M chrome/chrome_renderer.gypi View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 8 chunks +14 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Lei Zhang
thestig@chromium.org changed reviewers: + sadrul@chromium.org
6 years, 3 months ago (2014-08-27 01:27:25 UTC) #1
Lei Zhang
This will conflict with your PDF CL, BTW.
6 years, 3 months ago (2014-08-27 01:27:25 UTC) #2
sadrul
lgtm
6 years, 3 months ago (2014-08-27 01:40:34 UTC) #3
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-27 01:48:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/513623002/1
6 years, 3 months ago (2014-08-27 01:49:08 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-27 02:42:03 UTC) #6
Lei Zhang
The CQ bit was unchecked by thestig@chromium.org
6 years, 3 months ago (2014-08-27 02:45:46 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 3 months ago (2014-08-27 07:04:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/513623002/20001
6 years, 3 months ago (2014-08-27 07:05:25 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel_swarming on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-27 08:35:18 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (20001) as 3f181716bc2d2369d869cadaee3ca07161f4250a
6 years, 3 months ago (2014-08-27 09:17:01 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:50:42 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a7d8801090fc2c2da5a84b9c600666395d4a5d54
Cr-Commit-Position: refs/heads/master@{#292125}

Powered by Google App Engine
This is Rietveld 408576698