Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: chrome/chrome_tests_unit.gypi

Issue 513623002: Cleanup: Combine some identical conditionals in chrome gyp targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix build Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 66bbe97823f5a7d01fb1246758d7889955843171..eabe7e69e0378116fe464eb5e70c5fb888a60edf 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -2183,15 +2183,6 @@
['exclude', '^browser/task_manager/'],
],
}],
- ['chromeos==0', {
- 'sources!': [
- # TODO(zturner): Enable this on Windows. See
- # BrowserWithTestWindowTest::SetUp() for a comment explaining why
- # this is broken.
- 'browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc',
- 'browser/ui/views/select_file_dialog_extension_unittest.cc',
- ],
- }],
['enable_mdns==1', {
'sources': [
'browser/local_discovery/privet_device_lister_unittest.cc',
@@ -2283,6 +2274,9 @@
'sources/': [
['exclude', '^browser/printing/'],
['exclude', '^browser/ui/webui/print_preview/'],
+ # No need for service process.
+ ['exclude', '^browser/service/'],
+ ['exclude', '^common/service_'],
['exclude', '^service/'],
],
'sources!': [
@@ -2351,8 +2345,13 @@
],
'sources!': [
'browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc',
- 'browser/notifications/login_state_notification_blocker_chromeos_unittest.cc',
'browser/extensions/api/log_private/syslog_parser_unittest.cc',
+ 'browser/notifications/login_state_notification_blocker_chromeos_unittest.cc',
+ # TODO(zturner): Enable this on Windows. See
+ # BrowserWithTestWindowTest::SetUp() for a comment explaining why
+ # this is broken.
+ 'browser/ui/views/frame/immersive_mode_controller_ash_unittest.cc',
+ 'browser/ui/views/select_file_dialog_extension_unittest.cc',
],
}],
['use_x11==1', {
@@ -2409,6 +2408,10 @@
'../third_party/ocmock/ocmock.gyp:ocmock',
'chrome',
],
+ 'sources': [
+ 'browser/media_galleries/fileapi/iphoto_file_util_unittest.cc',
+ 'utility/media_galleries/iphoto_library_parser_unittest.cc',
+ ],
'sources!': [
'browser/ui/tests/ui_gfx_image_unittest.cc',
'tools/convert_dict/convert_dict_unittest.cc',
@@ -2443,12 +2446,6 @@
'utility/media_galleries/pmp_column_reader_unittest.cc',
],
}],
- ['OS=="mac"', {
- 'sources': [
- 'browser/media_galleries/fileapi/iphoto_file_util_unittest.cc',
- 'utility/media_galleries/iphoto_library_parser_unittest.cc',
- ],
- }],
['enable_rlz!=0', {
'dependencies': [
'../rlz/rlz.gyp:test_support_rlz',
@@ -2636,6 +2633,7 @@
['exclude', '^browser/captive_portal/'],
['exclude', '^browser/diagnostics/'],
['exclude', '^browser/first_run/'],
+ ['exclude', '^browser/importer/'],
['exclude', '^browser/lifetime/'],
['exclude', '^browser/media_galleries/'],
['exclude', '^browser/net/firefox_*'],
@@ -2678,14 +2676,6 @@
'browser/download/download_dir_policy_handler_unittest.cc'
],
}],
- ['enable_printing!=1', {
- 'sources/': [
- # No need for service process.
- ['exclude', '^browser/service/'],
- ['exclude', '^common/service_'],
- ['exclude', '^service/'],
- ],
- }],
['enable_themes==0', {
'sources!': [
'browser/ui/webui/theme_source_unittest.cc',
@@ -2712,12 +2702,6 @@
'common/net/x509_certificate_model_unittest.cc',
],
}],
- ['OS=="android"', {
- 'sources/': [
- # Android doesn't build the importer.
- ['exclude', '^browser/importer/'],
- ],
- }],
['enable_managed_users!=1', {
'sources/': [
['exclude', '^browser/supervised_user/'],
« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698