Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java

Issue 513563002: Fix Issue 18628 by refixing Issue 18468 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
index 00101f128094e90a894c6e6921965885f2afb58b..3294926d4839add65644858ed51d5c4d51be907b 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/type/TypeParameterTypeImpl.java
@@ -13,8 +13,6 @@
*/
package com.google.dart.engine.internal.type;
-import com.google.dart.engine.element.Element;
-import com.google.dart.engine.element.LibraryElement;
import com.google.dart.engine.element.TypeParameterElement;
import com.google.dart.engine.internal.element.ElementPair;
import com.google.dart.engine.type.Type;
@@ -37,11 +35,6 @@ public class TypeParameterTypeImpl extends TypeImpl implements TypeParameterType
public static final TypeParameterType[] EMPTY_ARRAY = new TypeParameterType[0];
/**
- * The name of the type Type from dart.core.
- */
- private static final String TYPE_CLASS_NAME = "Type"; //$NON-NLS-1$
-
- /**
* Return an array containing the type parameter types defined by the given array of type
* parameter elements.
*
@@ -133,15 +126,6 @@ public class TypeParameterTypeImpl extends TypeImpl implements TypeParameterType
private boolean isMoreSpecificThan(Type s, Set<Type> visitedTypes, boolean withDynamic,
Set<TypePair> visitedTypePairs) {
//
- // If s is of type Type from dart.core, return true
- //
- Element sElement = s.getElement();
- LibraryElement sLibrary = sElement != null ? sElement.getLibrary() : null;
- if (sLibrary != null && sLibrary.isDartCore() && s.getName().equals(TYPE_CLASS_NAME)) {
- return true;
- }
-
- //
// T is a type parameter and S is the upper bound of T.
//
Type bound = getElement().getBound();

Powered by Google App Engine
This is Rietveld 408576698