Fix Issue 18628 by refixing Issue 18468

editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java

Index: editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java
diff --git a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java
index 47ba93ffb04391980b3157fb2302a892a2b772d9..b323aa745ea19ac9a7f57a6d3274573914aa7802 100644
--- a/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java
+++ b/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java
@@ -252,6 +252,17 @@ public class StaticTypeWarningCodeTest extends ResolverTestCase {
     verify(source);
   }
 
+  public void test_invalidAssignment_regressionInR35501() throws Exception {

[jwren, 2014/08/27 06:59:39]

Change R35501 to issue number.

[karlklose, 2014/08/28 06:59:54]

Shouldn't we add these as language tests? Every tool that attempts to type check
should be checked against these cases.

[Nathan Collins, 2014/08/28 22:23:17]

Sounds good. How do I add a "language test"?

[karlklose, 2014/08/29 08:01:09]

Add a test in tests/language. To test warnings you should create a multi-test,
where you add a triple-slash ('///') comment to the line where the where the
warning should appear:

         class C<T> {
           T t = int;  /// 01: static type-warning
         }

The test framework will create a version with and one without the line. The one
without it should run without warnings and errors and the one with the line
included should produce the result that is in the comment.

Make sure to run the VM and dart2js on the test as well. They both don't type
check the expression, but they would throw when executing the test above in
checked mode, so you have to catch the exception (see
tests/language/malbounded_type_cast2_test.dart for an example).

[Nathan Collins, 2014/08/29 20:13:37]

Thanks! I added the tests here: https://codereview.chromium.org/521773003 .

The VM and dart2js don't seem to have any trouble in checked mode with these
tests,
so I did not follow the tests/language/malbounded_type_cast2_test example. But
maybe
I ran the VM and dart2js tests incorrectly? The way I ran them is described in
the
tests/README I added.

[karlklose, 2014/09/01 07:35:23]

Writing tests for the VM and dart2js is a bit tricky, as they only compile what
(they think) is needed. This means that you have to actually use what you want
to test. I'll add comments to the test in the other CL.

+    // https://code.google.com/p/dart/issues/detail?id=18628
+    Source source = addSource(createSource(//
+        "class C<T> {",
+        "  T t = int;",
+        "}"));
+    resolve(source);
+    assertErrors(source, StaticTypeWarningCode.INVALID_ASSIGNMENT);
+    verify(source);
+  }
+
   public void test_invalidAssignment_staticVariable() throws Exception {
     Source source = addSource(createSource(//
         "class A {",
@@ -617,6 +628,16 @@ public class StaticTypeWarningCodeTest extends ResolverTestCase {
     verify(source);
   }
 
+  public void test_typeArgumentNotMatchingBounds_extends_regressionInR35501() throws Exception {

[jwren, 2014/08/27 06:59:39]

Same here.

+    // https://code.google.com/p/dart/issues/detail?id=18628
+    Source source = addSource(createSource(//
+        "class X<T extends Type> {}",
+        "class Y<U> extends X<U> {}"));
+    resolve(source);
+    assertErrors(source, StaticTypeWarningCode.TYPE_ARGUMENT_NOT_MATCHING_BOUNDS);
+    verify(source);
+  }
+
   public void test_typeArgumentNotMatchingBounds_fieldFormalParameter() throws Exception {
     Source source = addSource(createSource(//
         "class A {}",