Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 513453002: Add CheckedMachAddressRange and its test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Add CheckedMachAddressRange and its test. TEST=util_test CheckedMachAddressRange.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/04842e0ca454

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -0 lines) Patch
A util/mac/checked_mach_address_range.h View 1 1 chunk +134 lines, -0 lines 0 comments Download
A util/mac/checked_mach_address_range.cc View 1 1 chunk +88 lines, -0 lines 0 comments Download
A util/mac/checked_mach_address_range_test.cc View 1 1 chunk +256 lines, -0 lines 0 comments Download
M util/util.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Mentovai
mark@chromium.org changed reviewers: + rsesek@chromium.org
6 years, 3 months ago (2014-08-26 22:07:17 UTC) #1
Mark Mentovai
This will be used by the Mach-O image readers.
6 years, 3 months ago (2014-08-26 22:07:17 UTC) #2
Robert Sesek
LGTM https://codereview.chromium.org/513453002/diff/1/util/mac/checked_mach_address_range.h File util/mac/checked_mach_address_range.h (right): https://codereview.chromium.org/513453002/diff/1/util/mac/checked_mach_address_range.h#newcode20 util/mac/checked_mach_address_range.h:20: #include "util/mac/process_reader.h" Optional: Could forward declare instead. https://codereview.chromium.org/513453002/diff/1/util/mac/checked_mach_address_range.h#newcode45 ...
6 years, 3 months ago (2014-08-28 13:58:30 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-08-28 17:47:32 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 04842e0ca454 (presubmit
successful).

Powered by Google App Engine
This is Rietveld 408576698