Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: util/mac/checked_mach_address_range_test.cc

Issue 513453002: Add CheckedMachAddressRange and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mac/checked_mach_address_range.cc ('k') | util/util.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/checked_mach_address_range_test.cc
diff --git a/util/mac/checked_mach_address_range_test.cc b/util/mac/checked_mach_address_range_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..392121dcc741c894a66b7d5cb9d64dc1989458e0
--- /dev/null
+++ b/util/mac/checked_mach_address_range_test.cc
@@ -0,0 +1,256 @@
+// Copyright 2014 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/mac/checked_mach_address_range.h"
+
+#include <mach/mach.h>
+
+#include <limits>
+
+#include "base/basictypes.h"
+#include "base/strings/stringprintf.h"
+#include "build/build_config.h"
+#include "gtest/gtest.h"
+#include "util/mac/process_reader.h"
+
+namespace {
+
+using namespace crashpad;
+
+#if defined(ARCH_CPU_64_BITS)
+const bool kValid64Invalid32 = true;
+#else
+const bool kValid64Invalid32 = false;
+#endif
+
+TEST(CheckedMachAddressRange, IsValid) {
+ const struct TestData {
+ mach_vm_address_t base;
+ mach_vm_size_t size;
+ bool valid;
+ } kTestData[] = {
+ {0, 0, true},
+ {0, 1, true},
+ {0, 2, true},
+ {0, 0x7fffffff, true},
+ {0, 0x80000000, true},
+ {0, 0xfffffffe, true},
+ {0, 0xffffffff, true},
+ {0, 0xffffffffffffffff, kValid64Invalid32},
+ {1, 0, true},
+ {1, 1, true},
+ {1, 2, true},
+ {1, 0x7fffffff, true},
+ {1, 0x80000000, true},
+ {1, 0xfffffffe, true},
+ {1, 0xffffffff, kValid64Invalid32},
+ {1, 0xfffffffffffffffe, kValid64Invalid32},
+ {1, 0xffffffffffffffff, false},
+ {0x7fffffff, 0, true},
+ {0x7fffffff, 1, true},
+ {0x7fffffff, 2, true},
+ {0x7fffffff, 0x7fffffff, true},
+ {0x7fffffff, 0x80000000, true},
+ {0x7fffffff, 0xfffffffe, kValid64Invalid32},
+ {0x7fffffff, 0xffffffff, kValid64Invalid32},
+ {0x80000000, 0, true},
+ {0x80000000, 1, true},
+ {0x80000000, 2, true},
+ {0x80000000, 0x7fffffff, true},
+ {0x80000000, 0x80000000, kValid64Invalid32},
+ {0x80000000, 0xfffffffe, kValid64Invalid32},
+ {0x80000000, 0xffffffff, kValid64Invalid32},
+ {0xfffffffe, 0, true},
+ {0xfffffffe, 1, true},
+ {0xfffffffe, 2, kValid64Invalid32},
+ {0xfffffffe, 0x7fffffff, kValid64Invalid32},
+ {0xfffffffe, 0x80000000, kValid64Invalid32},
+ {0xfffffffe, 0xfffffffe, kValid64Invalid32},
+ {0xfffffffe, 0xffffffff, kValid64Invalid32},
+ {0xffffffff, 0, true},
+ {0xffffffff, 1, kValid64Invalid32},
+ {0xffffffff, 2, kValid64Invalid32},
+ {0xffffffff, 0x7fffffff, kValid64Invalid32},
+ {0xffffffff, 0x80000000, kValid64Invalid32},
+ {0xffffffff, 0xfffffffe, kValid64Invalid32},
+ {0xffffffff, 0xffffffff, kValid64Invalid32},
+ {0x7fffffffffffffff, 0, kValid64Invalid32},
+ {0x7fffffffffffffff, 1, kValid64Invalid32},
+ {0x7fffffffffffffff, 2, kValid64Invalid32},
+ {0x7fffffffffffffff, 0x7fffffffffffffff, kValid64Invalid32},
+ {0x7fffffffffffffff, 0x8000000000000000, kValid64Invalid32},
+ {0x7fffffffffffffff, 0x8000000000000001, false},
+ {0x7fffffffffffffff, 0xfffffffffffffffe, false},
+ {0x7fffffffffffffff, 0xffffffffffffffff, false},
+ {0x8000000000000000, 0, kValid64Invalid32},
+ {0x8000000000000000, 1, kValid64Invalid32},
+ {0x8000000000000000, 2, kValid64Invalid32},
+ {0x8000000000000000, 0x7fffffffffffffff, kValid64Invalid32},
+ {0x8000000000000000, 0x8000000000000000, false},
+ {0x8000000000000000, 0x8000000000000001, false},
+ {0x8000000000000000, 0xfffffffffffffffe, false},
+ {0x8000000000000000, 0xffffffffffffffff, false},
+ {0xfffffffffffffffe, 0, kValid64Invalid32},
+ {0xfffffffffffffffe, 1, kValid64Invalid32},
+ {0xfffffffffffffffe, 2, false},
+ {0xffffffffffffffff, 0, kValid64Invalid32},
+ {0xffffffffffffffff, 1, false},
+ };
+
+ ProcessReader process_reader;
+ ASSERT_TRUE(process_reader.Initialize(mach_task_self()));
+
+ for (size_t index = 0; index < arraysize(kTestData); ++index) {
+ const TestData& testcase = kTestData[index];
+ SCOPED_TRACE(base::StringPrintf("index %zu, base 0x%llx, size 0x%llx",
+ index,
+ testcase.base,
+ testcase.size));
+
+ CheckedMachAddressRange range(
+ &process_reader, testcase.base, testcase.size);
+ EXPECT_EQ(testcase.valid, range.IsValid());
+ }
+}
+
+TEST(CheckedMachAddressRange, ContainsValue) {
+ const struct TestData {
+ mach_vm_address_t value;
+ bool valid;
+ } kTestData[] = {
+ {0, false},
+ {1, false},
+ {0x1fff, false},
+ {0x2000, true},
+ {0x2001, true},
+ {0x2ffe, true},
+ {0x2fff, true},
+ {0x3000, false},
+ {0x3001, false},
+ {0x7fffffff, false},
+ {0x80000000, false},
+ {0x80000001, false},
+ {0x80001fff, false},
+ {0x80002000, false},
+ {0x80002001, false},
+ {0x80002ffe, false},
+ {0x80002fff, false},
+ {0x80003000, false},
+ {0x80003001, false},
+ {0xffffcfff, false},
+ {0xffffdfff, false},
+ {0xffffefff, false},
+ {0xffffffff, false},
+ {0x100000000, false},
+ {0xffffffffffffffff, false},
+ };
+
+ ProcessReader process_reader;
+ ASSERT_TRUE(process_reader.Initialize(mach_task_self()));
+
+ CheckedMachAddressRange parent_range(&process_reader, 0x2000, 0x1000);
+ ASSERT_TRUE(parent_range.IsValid());
+
+ for (size_t index = 0; index < arraysize(kTestData); ++index) {
+ const TestData& testcase = kTestData[index];
+ SCOPED_TRACE(
+ base::StringPrintf("index %zu, value 0x%llx", index, testcase.value));
+
+ EXPECT_EQ(testcase.valid, parent_range.ContainsValue(testcase.value));
+ }
+
+ CheckedMachAddressRange parent_range_64(&process_reader, 0x100000000, 0x1000);
+ ASSERT_EQ(kValid64Invalid32, parent_range_64.IsValid());
+ if (parent_range_64.IsValid()) {
+ EXPECT_FALSE(parent_range_64.ContainsValue(0xffffffff));
+ EXPECT_TRUE(parent_range_64.ContainsValue(0x100000000));
+ EXPECT_TRUE(parent_range_64.ContainsValue(0x100000001));
+ EXPECT_TRUE(parent_range_64.ContainsValue(0x100000fff));
+ EXPECT_FALSE(parent_range_64.ContainsValue(0x100001000));
+ }
+}
+
+TEST(CheckedMachAddressRange, ContainsRange) {
+ const struct TestData {
+ mach_vm_address_t base;
+ mach_vm_size_t size;
+ bool valid;
+ } kTestData[] = {
+ {0, 0, false},
+ {0, 1, false},
+ {0x2000, 0x1000, true},
+ {0, 0x2000, false},
+ {0x3000, 0x1000, false},
+ {0x1800, 0x1000, false},
+ {0x2800, 0x1000, false},
+ {0x2000, 0x800, true},
+ {0x2800, 0x800, true},
+ {0x2400, 0x800, true},
+ {0x2800, 0, true},
+ {0x2000, 0xffffdfff, false},
+ {0x2800, 0xffffd7ff, false},
+ {0x3000, 0xffffcfff, false},
+ {0xfffffffe, 1, false},
+ {0xffffffff, 0, false},
+ {0x1fff, 0, false},
+ {0x2000, 0, true},
+ {0x2001, 0, true},
+ {0x2fff, 0, true},
+ {0x3000, 0, true},
+ {0x3001, 0, false},
+ {0x1fff, 1, false},
+ {0x2000, 1, true},
+ {0x2001, 1, true},
+ {0x2fff, 1, true},
+ {0x3000, 1, false},
+ {0x3001, 1, false},
+ };
+
+ ProcessReader process_reader;
+ ASSERT_TRUE(process_reader.Initialize(mach_task_self()));
+
+ CheckedMachAddressRange parent_range(&process_reader, 0x2000, 0x1000);
+ ASSERT_TRUE(parent_range.IsValid());
+
+ for (size_t index = 0; index < arraysize(kTestData); ++index) {
+ const TestData& testcase = kTestData[index];
+ SCOPED_TRACE(base::StringPrintf("index %zu, base 0x%llx, size 0x%llx",
+ index,
+ testcase.base,
+ testcase.size));
+
+ CheckedMachAddressRange child_range(
+ &process_reader, testcase.base, testcase.size);
+ ASSERT_TRUE(child_range.IsValid());
+ EXPECT_EQ(testcase.valid, parent_range.ContainsRange(child_range));
+ }
+
+ CheckedMachAddressRange parent_range_64(&process_reader, 0x100000000, 0x1000);
+ ASSERT_EQ(kValid64Invalid32, parent_range_64.IsValid());
+ if (parent_range_64.IsValid()) {
+ CheckedMachAddressRange child_range_64(&process_reader, 0xffffffff, 2);
+ EXPECT_FALSE(parent_range_64.ContainsRange(child_range_64));
+
+ child_range_64.SetRange(&process_reader, 0x100000000, 2);
+ EXPECT_TRUE(parent_range_64.ContainsRange(child_range_64));
+
+ child_range_64.SetRange(&process_reader, 0x100000ffe, 2);
+ EXPECT_TRUE(parent_range_64.ContainsRange(child_range_64));
+
+ child_range_64.SetRange(&process_reader, 0x100000fff, 2);
+ EXPECT_FALSE(parent_range_64.ContainsRange(child_range_64));
+ }
+}
+
+} // namespace
« no previous file with comments | « util/mac/checked_mach_address_range.cc ('k') | util/util.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698